revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Fix an errant "switch ... continue"

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/unhandled-exception-on-create-task/2062>.

This construction has the same behavior as "switch ... break" but is unconventional. PHP 7.3 started warning about it because it's likely a mistake.

Test Plan: Created a task, edited a task owner. The new code is functionally identical to the old code.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19772
This commit is contained in:
epriestley 2018-11-05 04:38:11 -08:00
parent 24a061f844
commit d2316e8025
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/maniphest/editor/ManiphestTransactionEditor.php
View file

@ -290,7 +290,7 @@ final class ManiphestTransactionEditor
$copy->setOwnerPHID($xaction->getNewValue()); $copy->setOwnerPHID($xaction->getNewValue());
break; break;
default: default:
continue; break;
} }
} }