1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00

Remove setOwners() from PhabricatorProjectQuery

Summary: I'm deprecating the concept of "owners" (which currently has no meaning in the actual application) in favor of policy-based controls. Remove the ability to query by it.

Test Plan: Grepped for setOwners(), no relevant hits. Browsed the project listing.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D3178
This commit is contained in:
epriestley 2012-08-07 11:54:14 -07:00
parent ed4a155c91
commit d25d9ddb01
2 changed files with 0 additions and 21 deletions

View file

@ -33,7 +33,6 @@ final class PhabricatorProjectListController
->setBaseURI(new PhutilURI('/project/filter/'))
->addLabel('User')
->addFilter('active', 'Active')
->addFilter('owned', 'Owned')
->addSpacer()
->addLabel('All')
->addFilter('all', 'All Projects')
@ -59,11 +58,6 @@ final class PhabricatorProjectListController
$query->setMembers(array($view_phid));
$query->withStatus(PhabricatorProjectQuery::STATUS_ACTIVE);
break;
case 'owned':
$table_header = 'Owned Projects';
$query->setOwners(array($view_phid));
$query->withStatus($status_filter);
break;
case 'allactive':
$status_filter = PhabricatorProjectQuery::STATUS_ACTIVE;
$table_header = 'Active Projects';

View file

@ -20,7 +20,6 @@ final class PhabricatorProjectQuery {
private $ids;
private $phids;
private $owners;
private $members;
private $status = 'status-any';
@ -60,11 +59,6 @@ final class PhabricatorProjectQuery {
return $this;
}
public function setOwners(array $owners) {
$this->owners = $owners;
return $this;
}
public function setMembers(array $members) {
$this->members = $members;
return $this;
@ -188,15 +182,6 @@ final class PhabricatorProjectQuery {
$affil_table = new PhabricatorProjectAffiliation();
$joins = array();
if ($this->owners) {
$joins[] = qsprintf(
$conn_r,
'JOIN %T owner ON owner.projectPHID = p.phid AND owner.isOwner = 1
AND owner.userPHID in (%Ls)',
$affil_table->getTableName(),
$this->owners);
}
if ($this->members) {
$joins[] = qsprintf(
$conn_r,