revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

[Redesign] Normalize header policy and object tags

Browse source 
Summary: Ref T8099, This adds a consistent background color to object and policy tags, and highlights them when they deviate from the normal. Still likely worth revamping 'closed' and 'review' state colors.

Test Plan: Review lots of diffs and tasks.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13399
This commit is contained in:
Chad Little 2015-06-23 12:03:46 +01:00
parent 1ccdb941b9
commit d27b3146d2
4 changed files with 16 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/
return array(
'names' => array(
'core.pkg.css' => '61e69662',
'core.pkg.css' => '0ea26c65',
'core.pkg.js' => 'a590b451',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => 'fe951924',
@ -134,7 +134,7 @@ return array(
'rsrc/css/phui/phui-fontkit.css' => '6790f776',
'rsrc/css/phui/phui-form-view.css' => 'a0e8f168',
'rsrc/css/phui/phui-form.css' => '17ce37a9',
'rsrc/css/phui/phui-header-view.css' => '3d78fd16',
'rsrc/css/phui/phui-header-view.css' => '541c6cc7',
'rsrc/css/phui/phui-icon.css' => '88ba9081',
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
@ -777,7 +777,7 @@ return array(
'phui-fontkit-css' => '6790f776',
'phui-form-css' => '17ce37a9',
'phui-form-view-css' => 'a0e8f168',
'phui-header-view-css' => '3d78fd16',
'phui-header-view-css' => '541c6cc7',
'phui-icon-view-css' => '88ba9081',
'phui-image-mask-css' => '5a8b09c8',
'phui-info-panel-css' => '27ea50a1',

2
src/applications/differential/constants/DifferentialRevisionStatus.php
View file

@ -68,7 +68,7 @@ final class DifferentialRevisionStatus extends Phobject {
$tag = phutil_tag(
'span',
array(
'class' => 'phui-header-'.$color.' plr',
'class' => 'phui-header-status phui-header-'.$color,
),
array(
$img,

2
src/view/phui/PHUIHeaderView.php
View file

@ -110,7 +110,7 @@ final class PHUIHeaderView extends AphrontTagView {
$tag = phutil_tag(
'span',
array(
'class' => "{$header_class} plr",
'class' => "phui-header-status {$header_class}",
),
array(
$img,

32
webroot/rsrc/css/phui/phui-header-view.css
View file

@ -144,47 +144,45 @@ body .phui-header-shell.phui-bleed-header
color: {$darkbluetext};
}
.policy-header-callout.policy-adjusted {
padding: 0 4px;
.policy-header-callout,
.phui-header-subheader .phui-header-status {
padding: 3px 9px;
border-radius: 3px;
background: {$lightbluebackground};
margin-right: 8px;
}
.policy-header-callout.policy-adjusted-weaker {
background: {$lightgreen};
border: 1px solid {$green};
background: {$sh-greenbackground};
}
.policy-header-callout.policy-adjusted-weaker .policy-link,
.policy-header-callout.policy-adjusted-weaker .phui-icon-view {
color: {$green};
color: {$sh-greentext};
}
.policy-header-callout.policy-adjusted-stronger {
background: {$lightred};
border: 1px solid {$red};
background: {$sh-redbackground};
}
.policy-header-callout.policy-adjusted-stronger .policy-link,
.policy-header-callout.policy-adjusted-stronger .phui-icon-view {
color: {$red};
color: {$sh-redtext};
}
.policy-header-callout.policy-adjusted-different {
background: {$lightorange};
border: 1px solid {$orange};
background: {$sh-orangebackground};
}
.policy-header-callout.policy-adjusted-different .policy-link,
.policy-header-callout.policy-adjusted-different .phui-icon-view {
color: {$orange};
color: {$sh-orangetext};
}
.phui-header-subheader .phui-header-status-dark {
color: {$sh-indigotext};
background: {$sh-indigobackground};
margin-right: 8px;
padding: 4px 8px;
border-radius: 3px;
}
.phui-header-subheader .phui-header-status-dark .phui-icon-view {
@ -194,19 +192,11 @@ body .phui-header-shell.phui-bleed-header
.phui-header-subheader .phui-header-status-red {
color: {$sh-redtext};
background: {$sh-redbackground};
margin-right: 8px;
padding: 4px 8px;
border-radius: 3px;
margin-right: 8px;
}
.phui-header-subheader .phui-header-status-green {
color: {$sh-greentext};
background: {$sh-greenbackground};
margin-right: 8px;
padding: 4px 8px;
border-radius: 3px;
margin-right: 8px;
}
.phui-header-action-links .phui-mobile-menu {