From d2935fd7bdc255cd415f640a90f21065a2dba943 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 12 Jul 2019 08:39:35 -0700 Subject: [PATCH] Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined Summary: See . This call should be `logInfo()`. Test Plan: - Purged `PHABRICATOR_INSTANCE` from my environment. In a Phacility development environment, it comes from loading `services/`. - Ran `bin/phd stop` with all daemons already stopped. - Before: bad call. - After: helpful error. - Ran some other `bin/phd start`, `bin/phd status`, etc., to kick the tires. - Grepped for remaining `writeInfo()` calls (found none). Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20649 --- .../management/PhabricatorDaemonManagementStatusWorkflow.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php b/src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php index 1f7ed951cb..d5af149869 100644 --- a/src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php +++ b/src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php @@ -22,7 +22,7 @@ final class PhabricatorDaemonManagementStatusWorkflow 'instance ("%s").', $instance)); } else { - $this->writeInfo( + $this->logInfo( pht('NO DAEMONS'), pht('There are no running daemon processes.')); }