From d2b7bb950440d80c76ab9ed83b85b4a63213ca8f Mon Sep 17 00:00:00 2001 From: Nick Harper Date: Tue, 26 Mar 2013 15:40:14 -0700 Subject: [PATCH] Fix title for phabricator home page Summary: My browser was showing the url of phabricator as the title instead of the real title. Fix it so the title set for the home page actually gets used. Test Plan: load phabricator and see "Bacon Ice Cream for Breakfast" as the title Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Differential Revision: https://secure.phabricator.com/D5428 --- src/applications/base/controller/PhabricatorController.php | 2 +- .../controller/PhabricatorDirectoryMainController.php | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php index e103b87d43..45ba5dc069 100644 --- a/src/applications/base/controller/PhabricatorController.php +++ b/src/applications/base/controller/PhabricatorController.php @@ -148,9 +148,9 @@ abstract class PhabricatorController extends AphrontController { $page = $this->buildStandardPageView(); $application = $this->getCurrentApplication(); + $page->setTitle(idx($options, 'title')); if ($application) { $page->setApplicationName($application->getName()); - $page->setTitle(idx($options, 'title')); if ($application->getTitleGlyph()) { $page->setGlyph($application->getTitleGlyph()); } diff --git a/src/applications/directory/controller/PhabricatorDirectoryMainController.php b/src/applications/directory/controller/PhabricatorDirectoryMainController.php index 52c347f56c..63f70ccc0b 100644 --- a/src/applications/directory/controller/PhabricatorDirectoryMainController.php +++ b/src/applications/directory/controller/PhabricatorDirectoryMainController.php @@ -65,10 +65,14 @@ final class PhabricatorDirectoryMainController $nav->appendChild($content); $nav->appendChild(new PhabricatorGlobalUploadTargetView()); + $title = PhabricatorEnv::getEnvConfig('phabricator.serious-business') ? + 'Phabricator' : + pht('Bacon Ice Cream for Breakfast'); + return $this->buildApplicationPage( $nav, array( - 'title' => 'Phabricator', + 'title' => $title, 'device' => true, )); }