revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment

Browse source 
Summary:
rPb48a22bf50a32895566e9aa66c1d7aff87a492b8 moved the call `$this->getTransactionCommentForSave()->save()` from within `PhabricatorAuditInlineComment` to the new (parent) class `PhabricatorInlineComment.php`, however the later does not define this function.

As the two child classes which extend `PhabricatorInlineComment` both implement `getTransactionCommentForSave()`, declare an abstract function in their parent class.

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25644
This commit is contained in:
Andre Klapper 2024-05-16 12:24:44 +02:00
parent 17b568b94f
commit d2bca2f32d
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/infrastructure/diff/interface/PhabricatorInlineComment.php
View file

@ -101,6 +101,11 @@ abstract class PhabricatorInlineComment
abstract public function supportsHiding();
abstract public function isHidden();
/**
* @return Phobject
*/
abstract public function getTransactionCommentForSave();
public function isDraft() {
return !$this->getTransactionPHID();
}