From d326c6096e6e952e61a6a8807ce30e23b2ada558 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 5 Jan 2016 18:07:11 -0800 Subject: [PATCH] Make unsubscribing from a project have an effect Summary: Fixes T10089. This did work at one point, but was broken by D12868, which got too aggressive about mailing members. We don't want to send mail to all members by default, only those who are subscribed. The parent implementation of `getMailCC()` handles this for us. Test Plan: Joined a project as users A and B. Unsubscribed with B. Made an edit. Before patch: both A and B got mail. After patch: only A got mail. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10089 Differential Revision: https://secure.phabricator.com/D14955 --- .../editor/PhabricatorProjectTransactionEditor.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php index 86748f6287..54440a6ee9 100644 --- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php +++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php @@ -597,12 +597,9 @@ final class PhabricatorProjectTransactionEditor } protected function getMailTo(PhabricatorLiskDAO $object) { - return $object->getMemberPHIDs(); - } - - protected function getMailCC(PhabricatorLiskDAO $object) { - $all = parent::getMailCC($object); - return array_diff($all, $object->getMemberPHIDs()); + return array( + $this->getActingAsPHID(), + ); } public function getMailTagsMap() {