From d3323d0b3d5c324a2fb5a21123413fbf8d6a226d Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 24 Jan 2013 16:29:47 -0800 Subject: [PATCH] Maniphest Detail view for mobile. Summary: I try to access tasks a lot on my phone, but its hard to parse. I'm sure most of this will get tossed with new transactions, but wanted to land it anyways. Test Plan: Test ticket details on iOS simulator and Chrome. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4619 --- src/__celerity_resource_map__.php | 98 +++++++++---------- .../ManiphestTaskDetailController.php | 12 +-- webroot/rsrc/css/aphront/panel-view.css | 1 - webroot/rsrc/css/aphront/transaction.css | 4 + .../maniphest/transaction-detail.css | 6 +- 5 files changed, 64 insertions(+), 57 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 68cb7ced1c..fd8db3484c 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -663,7 +663,7 @@ celerity_register_resource_map(array( ), 'aphront-panel-view-css' => array( - 'uri' => '/res/e4ad41d7/rsrc/css/aphront/panel-view.css', + 'uri' => '/res/789ff5e5/rsrc/css/aphront/panel-view.css', 'type' => 'css', 'requires' => array( @@ -2337,7 +2337,7 @@ celerity_register_resource_map(array( ), 'maniphest-transaction-detail-css' => array( - 'uri' => '/res/24e5862f/rsrc/css/application/maniphest/transaction-detail.css', + 'uri' => '/res/fb430d3e/rsrc/css/application/maniphest/transaction-detail.css', 'type' => 'css', 'requires' => array( @@ -2895,7 +2895,7 @@ celerity_register_resource_map(array( ), 'phabricator-transaction-view-css' => array( - 'uri' => '/res/731959fb/rsrc/css/aphront/transaction.css', + 'uri' => '/res/d3599152/rsrc/css/aphront/transaction.css', 'type' => 'css', 'requires' => array( @@ -3254,7 +3254,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - '4dff6da8' => + 'd770a9ec' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -3298,7 +3298,7 @@ celerity_register_resource_map(array( 36 => 'phabricator-object-item-list-view-css', 37 => 'global-drag-and-drop-css', ), - 'uri' => '/res/pkg/4dff6da8/core.pkg.css', + 'uri' => '/res/pkg/d770a9ec/core.pkg.css', 'type' => 'css', ), '66dca903' => @@ -3457,7 +3457,7 @@ celerity_register_resource_map(array( 'uri' => '/res/pkg/fbeded59/javelin.pkg.js', 'type' => 'js', ), - 'fcdf4c24' => + 'e30a3fa8' => array( 'name' => 'maniphest.pkg.css', 'symbols' => @@ -3467,7 +3467,7 @@ celerity_register_resource_map(array( 2 => 'aphront-attached-file-view-css', 3 => 'phabricator-project-tag-css', ), - 'uri' => '/res/pkg/fcdf4c24/maniphest.pkg.css', + 'uri' => '/res/pkg/e30a3fa8/maniphest.pkg.css', 'type' => 'css', ), '7707de41' => @@ -3487,20 +3487,20 @@ celerity_register_resource_map(array( ), 'reverse' => array( - 'aphront-attached-file-view-css' => 'fcdf4c24', - 'aphront-crumbs-view-css' => '4dff6da8', - 'aphront-dialog-view-css' => '4dff6da8', - 'aphront-error-view-css' => '4dff6da8', - 'aphront-form-view-css' => '4dff6da8', + 'aphront-attached-file-view-css' => 'e30a3fa8', + 'aphront-crumbs-view-css' => 'd770a9ec', + 'aphront-dialog-view-css' => 'd770a9ec', + 'aphront-error-view-css' => 'd770a9ec', + 'aphront-form-view-css' => 'd770a9ec', 'aphront-headsup-action-list-view-css' => 'ec01d039', - 'aphront-headsup-view-css' => '4dff6da8', - 'aphront-list-filter-view-css' => '4dff6da8', - 'aphront-pager-view-css' => '4dff6da8', - 'aphront-panel-view-css' => '4dff6da8', - 'aphront-table-view-css' => '4dff6da8', - 'aphront-tokenizer-control-css' => '4dff6da8', - 'aphront-tooltip-css' => '4dff6da8', - 'aphront-typeahead-control-css' => '4dff6da8', + 'aphront-headsup-view-css' => 'd770a9ec', + 'aphront-list-filter-view-css' => 'd770a9ec', + 'aphront-pager-view-css' => 'd770a9ec', + 'aphront-panel-view-css' => 'd770a9ec', + 'aphront-table-view-css' => 'd770a9ec', + 'aphront-tokenizer-control-css' => 'd770a9ec', + 'aphront-tooltip-css' => 'd770a9ec', + 'aphront-typeahead-control-css' => 'd770a9ec', 'differential-changeset-view-css' => 'ec01d039', 'differential-core-view-css' => 'ec01d039', 'differential-inline-comment-editor' => 'ac53d36a', @@ -3514,7 +3514,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => 'ec01d039', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => '4dff6da8', + 'global-drag-and-drop-css' => 'd770a9ec', 'inline-comment-summary-css' => 'ec01d039', 'javelin-aphlict' => '66dca903', 'javelin-behavior' => 'fbeded59', @@ -3584,48 +3584,48 @@ celerity_register_resource_map(array( 'javelin-util' => 'fbeded59', 'javelin-vector' => 'fbeded59', 'javelin-workflow' => 'fbeded59', - 'lightbox-attachment-css' => '4dff6da8', - 'maniphest-task-summary-css' => 'fcdf4c24', - 'maniphest-transaction-detail-css' => 'fcdf4c24', + 'lightbox-attachment-css' => 'd770a9ec', + 'maniphest-task-summary-css' => 'e30a3fa8', + 'maniphest-transaction-detail-css' => 'e30a3fa8', 'phabricator-busy' => '66dca903', 'phabricator-content-source-view-css' => 'ec01d039', - 'phabricator-core-buttons-css' => '4dff6da8', - 'phabricator-core-css' => '4dff6da8', - 'phabricator-crumbs-view-css' => '4dff6da8', - 'phabricator-directory-css' => '4dff6da8', + 'phabricator-core-buttons-css' => 'd770a9ec', + 'phabricator-core-css' => 'd770a9ec', + 'phabricator-crumbs-view-css' => 'd770a9ec', + 'phabricator-directory-css' => 'd770a9ec', 'phabricator-drag-and-drop-file-upload' => 'ac53d36a', 'phabricator-dropdown-menu' => '66dca903', 'phabricator-file-upload' => '66dca903', - 'phabricator-filetree-view-css' => '4dff6da8', - 'phabricator-flag-css' => '4dff6da8', - 'phabricator-form-view-css' => '4dff6da8', - 'phabricator-header-view-css' => '4dff6da8', - 'phabricator-jump-nav' => '4dff6da8', + 'phabricator-filetree-view-css' => 'd770a9ec', + 'phabricator-flag-css' => 'd770a9ec', + 'phabricator-form-view-css' => 'd770a9ec', + 'phabricator-header-view-css' => 'd770a9ec', + 'phabricator-jump-nav' => 'd770a9ec', 'phabricator-keyboard-shortcut' => '66dca903', 'phabricator-keyboard-shortcut-manager' => '66dca903', - 'phabricator-main-menu-view' => '4dff6da8', + 'phabricator-main-menu-view' => 'd770a9ec', 'phabricator-menu-item' => '66dca903', - 'phabricator-nav-view-css' => '4dff6da8', + 'phabricator-nav-view-css' => 'd770a9ec', 'phabricator-notification' => '66dca903', - 'phabricator-notification-css' => '4dff6da8', - 'phabricator-notification-menu-css' => '4dff6da8', - 'phabricator-object-item-list-view-css' => '4dff6da8', + 'phabricator-notification-css' => 'd770a9ec', + 'phabricator-notification-menu-css' => 'd770a9ec', + 'phabricator-object-item-list-view-css' => 'd770a9ec', 'phabricator-object-selector-css' => 'ec01d039', 'phabricator-paste-file-upload' => '66dca903', 'phabricator-prefab' => '66dca903', - 'phabricator-project-tag-css' => 'fcdf4c24', - 'phabricator-remarkup-css' => '4dff6da8', + 'phabricator-project-tag-css' => 'e30a3fa8', + 'phabricator-remarkup-css' => 'd770a9ec', 'phabricator-shaped-request' => 'ac53d36a', - 'phabricator-side-menu-view-css' => '4dff6da8', - 'phabricator-standard-page-view' => '4dff6da8', + 'phabricator-side-menu-view-css' => 'd770a9ec', + 'phabricator-standard-page-view' => 'd770a9ec', 'phabricator-textareautils' => '66dca903', 'phabricator-tooltip' => '66dca903', - 'phabricator-transaction-view-css' => '4dff6da8', - 'phabricator-zindex-css' => '4dff6da8', - 'sprite-apps-large-css' => '4dff6da8', - 'sprite-gradient-css' => '4dff6da8', - 'sprite-icon-css' => '4dff6da8', - 'sprite-menu-css' => '4dff6da8', - 'syntax-highlighting-css' => '4dff6da8', + 'phabricator-transaction-view-css' => 'd770a9ec', + 'phabricator-zindex-css' => 'd770a9ec', + 'sprite-apps-large-css' => 'd770a9ec', + 'sprite-gradient-css' => 'd770a9ec', + 'sprite-icon-css' => 'd770a9ec', + 'sprite-menu-css' => 'd770a9ec', + 'syntax-highlighting-css' => 'd770a9ec', ), )); diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php index 28a769c7ea..5bdb168d77 100644 --- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php +++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php @@ -302,16 +302,14 @@ final class ManiphestTaskDetailController extends ManiphestController { 'tokenizers' => $tokenizer_map, )); - $comment_panel = new AphrontPanelView(); - $comment_panel->appendChild($comment_form); - $comment_panel->addClass('aphront-panel-accent'); - $comment_panel->setHeader($is_serious ? 'Add Comment' : 'Weigh In'); + $comment_header = id(new PhabricatorHeaderView()) + ->setHeader($is_serious ? pht('Add Comment') : pht('Weigh In')); $preview_panel = '
- Loading preview... + '.pht('Loading preview...').'
'; @@ -346,12 +344,14 @@ final class ManiphestTaskDetailController extends ManiphestController { $actions, $properties, $transaction_view, - $comment_panel, + $comment_header, + $comment_form, $preview_panel, ), array( 'title' => 'T'.$task->getID().' '.$task->getTitle(), 'pageObjects' => array($task->getPHID()), + 'device' => true, )); } diff --git a/webroot/rsrc/css/aphront/panel-view.css b/webroot/rsrc/css/aphront/panel-view.css index 11c5a760a0..ce5d3944a3 100644 --- a/webroot/rsrc/css/aphront/panel-view.css +++ b/webroot/rsrc/css/aphront/panel-view.css @@ -83,7 +83,6 @@ .aphront-panel-preview { background: #fbfbfb; border-bottom: 1px solid #aaaaaa; - margin: -1em 2em 2em; padding: 15px 20px; } diff --git a/webroot/rsrc/css/aphront/transaction.css b/webroot/rsrc/css/aphront/transaction.css index 334ec550db..6eb4052f77 100644 --- a/webroot/rsrc/css/aphront/transaction.css +++ b/webroot/rsrc/css/aphront/transaction.css @@ -16,6 +16,10 @@ margin-left: 54px; } +.device-phone .phabricator-transaction-detail { + margin: 0; +} + .phabricator-transaction-header { background: #f3f3f3; padding: 4px 1em; diff --git a/webroot/rsrc/css/application/maniphest/transaction-detail.css b/webroot/rsrc/css/application/maniphest/transaction-detail.css index 3bd1a6b9f0..42987f2abb 100644 --- a/webroot/rsrc/css/application/maniphest/transaction-detail.css +++ b/webroot/rsrc/css/application/maniphest/transaction-detail.css @@ -3,7 +3,11 @@ */ .maniphest-transaction-list-view { - padding: 0 2em; + padding: 0 20px;; +} + +.device-phone .maniphest-transaction-list-view { + padding: 0 10px; } .maniphest-transaction-list-view .anchor-target {