Fixed a bug in Image Macros where the image URL was wrong

Summary: Image URLs were accidentally inaccurate due to the macro ID being overwritten by the file ID when searching for users

Test Plan: Visited the macro page and searched for my own macros. They are now clickable.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T3193

Differential Revision: https://secure.phabricator.com/D5936

src/applications/macro/query/PhabricatorMacroQuery.php

@@ -52,7 +52,7 @@ final class PhabricatorMacroQuery
 
     $rows = queryfx_all(
       $conn,
-      'SELECT * FROM %T m %Q %Q %Q %Q',
+      'SELECT m.* FROM %T m %Q %Q %Q %Q',
       $macro_table->getTableName(),
       $this->buildJoinClause($conn),
       $this->buildWhereClause($conn),