From d446ee02075aee1637bce0a7a8ca6bf4a030da22 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sun, 21 Jul 2013 13:40:20 -0700 Subject: [PATCH] Fix a variable being incorrectly overridden in Asana sync. Auditors: btrahan --- src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php b/src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php index 4c4f0cd4a6..0f0783ce26 100644 --- a/src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php +++ b/src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php @@ -85,8 +85,8 @@ final class DoorkeeperBridgeAsana extends DoorkeeperBridge { foreach ($refs as $ref) { $ref->setAttribute('name', pht('Asana Task %s', $ref->getObjectID())); - $failed = idx($failed, $ref->getObjectKey()); - if ($failed) { + $did_fail = idx($failed, $ref->getObjectKey()); + if ($did_fail) { $ref->setSyncFailed(true); continue; }