revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Fix an issue with 1up diff block rendering for added or removed blocks

Browse source 
Summary: Ref T13425. When a change adds or removes a block (vs adding or removing a document, or changing a block), we currently try to render `null` as cell content in the unified view. Make this check broader to catch both "no opposite document" and "no opposite cell".

Test Plan: {F7008772}

Subscribers: artms

Maniphest Tasks: T13425

Differential Revision: https://secure.phabricator.com/D20897
This commit is contained in:
epriestley 2019-11-08 07:33:16 -08:00
parent 502ca4767e
commit d4491ddc22
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
View file

@ -371,7 +371,7 @@ final class DifferentialChangesetOneUpRenderer
$cell_classes = $block_diff->getNewClasses();
}
} else if ($row_type === 'old') {
if (!$old_ref) {
if (!$old_ref || !$old) {
continue;
}
@ -384,7 +384,7 @@ final class DifferentialChangesetOneUpRenderer
$new_key = null;
} else if ($row_type === 'new') {
if (!$new_ref) {
if (!$new_ref || !$new) {
continue;
}