From d504a4d7df42ff3d9769edc4541f272c5864d2cc Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 29 Jan 2014 10:41:51 -0800 Subject: [PATCH] Fix Maniphest status change previews Summary: See IRC. This will be obsoleted by ApplicationTransactions eventually, but fix issues with stauts change previews for now. Specifically, if you select "Reopen Task", it incorrectly previews as "x created this task" because the old state is not set correctly. Test Plan: Selected "Reopen Task", saw a preview with the correct language. Reviewers: chad, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D8094 --- .../controller/ManiphestTransactionPreviewController.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/applications/maniphest/controller/ManiphestTransactionPreviewController.php b/src/applications/maniphest/controller/ManiphestTransactionPreviewController.php index eca224d115..826579333e 100644 --- a/src/applications/maniphest/controller/ManiphestTransactionPreviewController.php +++ b/src/applications/maniphest/controller/ManiphestTransactionPreviewController.php @@ -95,6 +95,11 @@ final class ManiphestTransactionPreviewController extends ManiphestController { $transaction->setOldValue($task->getProjectPHIDs()); $transaction->setNewValue($value); break; + case ManiphestTransaction::TYPE_STATUS: + $phids = array(); + $transaction->setOldvalue($task->getStatus()); + $transaction->setNewValue($value); + break; default: $phids = array(); $transaction->setNewValue($value);