From d521e60e70aef856e542757b002a8c1cb3ea75cc Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 2 Jul 2013 15:20:54 -0700 Subject: [PATCH] Make "Edit Query" a more visible button in ApplicationSearch Summary: Ref T2625. See disucssion in D6347. Test Plan: {F48515} {F48516} {F48517} {F48518} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2625 Differential Revision: https://secure.phabricator.com/D6348 --- src/__celerity_resource_map__.php | 90 +++++++++---------- src/view/layout/AphrontListFilterView.php | 4 +- webroot/rsrc/css/aphront/list-filter-view.css | 23 +++-- 3 files changed, 63 insertions(+), 54 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 2d1ba4b3af..68cc9d29da 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -823,7 +823,7 @@ celerity_register_resource_map(array( ), 'aphront-list-filter-view-css' => array( - 'uri' => '/res/185a194b/rsrc/css/aphront/list-filter-view.css', + 'uri' => '/res/ac995ae2/rsrc/css/aphront/list-filter-view.css', 'type' => 'css', 'requires' => array( @@ -4073,7 +4073,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - '60bbab00' => + 'c4be3603' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -4121,7 +4121,7 @@ celerity_register_resource_map(array( 40 => 'phabricator-property-list-view-css', 41 => 'phabricator-tag-view-css', ), - 'uri' => '/res/pkg/60bbab00/core.pkg.css', + 'uri' => '/res/pkg/c4be3603/core.pkg.css', 'type' => 'css', ), 'f2ad0683' => @@ -4315,16 +4315,16 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => 'adc3c36d', - 'aphront-dialog-view-css' => '60bbab00', - 'aphront-error-view-css' => '60bbab00', - 'aphront-form-view-css' => '60bbab00', - 'aphront-list-filter-view-css' => '60bbab00', - 'aphront-pager-view-css' => '60bbab00', - 'aphront-panel-view-css' => '60bbab00', - 'aphront-table-view-css' => '60bbab00', - 'aphront-tokenizer-control-css' => '60bbab00', - 'aphront-tooltip-css' => '60bbab00', - 'aphront-typeahead-control-css' => '60bbab00', + 'aphront-dialog-view-css' => 'c4be3603', + 'aphront-error-view-css' => 'c4be3603', + 'aphront-form-view-css' => 'c4be3603', + 'aphront-list-filter-view-css' => 'c4be3603', + 'aphront-pager-view-css' => 'c4be3603', + 'aphront-panel-view-css' => 'c4be3603', + 'aphront-table-view-css' => 'c4be3603', + 'aphront-tokenizer-control-css' => 'c4be3603', + 'aphront-tooltip-css' => 'c4be3603', + 'aphront-typeahead-control-css' => 'c4be3603', 'differential-changeset-view-css' => 'dd27a69b', 'differential-core-view-css' => 'dd27a69b', 'differential-inline-comment-editor' => '9488bb69', @@ -4338,7 +4338,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => 'dd27a69b', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => '60bbab00', + 'global-drag-and-drop-css' => 'c4be3603', 'inline-comment-summary-css' => 'dd27a69b', 'javelin-aphlict' => 'f2ad0683', 'javelin-behavior' => 'a9f14d76', @@ -4412,55 +4412,55 @@ celerity_register_resource_map(array( 'javelin-util' => 'a9f14d76', 'javelin-vector' => 'a9f14d76', 'javelin-workflow' => 'a9f14d76', - 'lightbox-attachment-css' => '60bbab00', + 'lightbox-attachment-css' => 'c4be3603', 'maniphest-task-summary-css' => 'adc3c36d', 'maniphest-transaction-detail-css' => 'adc3c36d', - 'phabricator-action-list-view-css' => '60bbab00', - 'phabricator-application-launch-view-css' => '60bbab00', + 'phabricator-action-list-view-css' => 'c4be3603', + 'phabricator-application-launch-view-css' => 'c4be3603', 'phabricator-busy' => 'f2ad0683', 'phabricator-content-source-view-css' => 'dd27a69b', - 'phabricator-core-css' => '60bbab00', - 'phabricator-crumbs-view-css' => '60bbab00', + 'phabricator-core-css' => 'c4be3603', + 'phabricator-crumbs-view-css' => 'c4be3603', 'phabricator-drag-and-drop-file-upload' => '9488bb69', 'phabricator-dropdown-menu' => 'f2ad0683', 'phabricator-file-upload' => 'f2ad0683', - 'phabricator-filetree-view-css' => '60bbab00', - 'phabricator-flag-css' => '60bbab00', - 'phabricator-form-view-css' => '60bbab00', - 'phabricator-header-view-css' => '60bbab00', + 'phabricator-filetree-view-css' => 'c4be3603', + 'phabricator-flag-css' => 'c4be3603', + 'phabricator-form-view-css' => 'c4be3603', + 'phabricator-header-view-css' => 'c4be3603', 'phabricator-hovercard' => 'f2ad0683', - 'phabricator-jump-nav' => '60bbab00', + 'phabricator-jump-nav' => 'c4be3603', 'phabricator-keyboard-shortcut' => 'f2ad0683', 'phabricator-keyboard-shortcut-manager' => 'f2ad0683', - 'phabricator-main-menu-view' => '60bbab00', + 'phabricator-main-menu-view' => 'c4be3603', 'phabricator-menu-item' => 'f2ad0683', - 'phabricator-nav-view-css' => '60bbab00', + 'phabricator-nav-view-css' => 'c4be3603', 'phabricator-notification' => 'f2ad0683', - 'phabricator-notification-css' => '60bbab00', - 'phabricator-notification-menu-css' => '60bbab00', - 'phabricator-object-item-list-view-css' => '60bbab00', + 'phabricator-notification-css' => 'c4be3603', + 'phabricator-notification-menu-css' => 'c4be3603', + 'phabricator-object-item-list-view-css' => 'c4be3603', 'phabricator-object-selector-css' => 'dd27a69b', 'phabricator-phtize' => 'f2ad0683', 'phabricator-prefab' => 'f2ad0683', 'phabricator-project-tag-css' => 'adc3c36d', - 'phabricator-property-list-view-css' => '60bbab00', - 'phabricator-remarkup-css' => '60bbab00', + 'phabricator-property-list-view-css' => 'c4be3603', + 'phabricator-remarkup-css' => 'c4be3603', 'phabricator-shaped-request' => '9488bb69', - 'phabricator-side-menu-view-css' => '60bbab00', - 'phabricator-standard-page-view' => '60bbab00', - 'phabricator-tag-view-css' => '60bbab00', + 'phabricator-side-menu-view-css' => 'c4be3603', + 'phabricator-standard-page-view' => 'c4be3603', + 'phabricator-tag-view-css' => 'c4be3603', 'phabricator-textareautils' => 'f2ad0683', 'phabricator-tooltip' => 'f2ad0683', - 'phabricator-transaction-view-css' => '60bbab00', - 'phabricator-zindex-css' => '60bbab00', - 'phui-button-css' => '60bbab00', - 'phui-form-css' => '60bbab00', - 'phui-icon-view-css' => '60bbab00', - 'phui-spacing-css' => '60bbab00', - 'sprite-apps-large-css' => '60bbab00', - 'sprite-gradient-css' => '60bbab00', - 'sprite-icons-css' => '60bbab00', - 'sprite-menu-css' => '60bbab00', - 'syntax-highlighting-css' => '60bbab00', + 'phabricator-transaction-view-css' => 'c4be3603', + 'phabricator-zindex-css' => 'c4be3603', + 'phui-button-css' => 'c4be3603', + 'phui-form-css' => 'c4be3603', + 'phui-icon-view-css' => 'c4be3603', + 'phui-spacing-css' => 'c4be3603', + 'sprite-apps-large-css' => 'c4be3603', + 'sprite-gradient-css' => 'c4be3603', + 'sprite-icons-css' => 'c4be3603', + 'sprite-menu-css' => 'c4be3603', + 'syntax-highlighting-css' => 'c4be3603', ), )); diff --git a/src/view/layout/AphrontListFilterView.php b/src/view/layout/AphrontListFilterView.php index 1b8c9df8da..99a956f38a 100644 --- a/src/view/layout/AphrontListFilterView.php +++ b/src/view/layout/AphrontListFilterView.php @@ -44,7 +44,7 @@ final class AphrontListFilterView extends AphrontView { $hide_action = javelin_tag( 'a', array( - 'class' => '', + 'class' => 'button grey', 'sigil' => 'reveal-content', 'id' => $hide_action_id, 'href' => $this->showHideHref, @@ -65,7 +65,7 @@ final class AphrontListFilterView extends AphrontView { $show_action = javelin_tag( 'a', array( - 'class' => '', + 'class' => 'button grey', 'sigil' => 'reveal-content', 'style' => 'display: none;', 'href' => '#', diff --git a/webroot/rsrc/css/aphront/list-filter-view.css b/webroot/rsrc/css/aphront/list-filter-view.css index 5003fe4189..8d054f039c 100644 --- a/webroot/rsrc/css/aphront/list-filter-view.css +++ b/webroot/rsrc/css/aphront/list-filter-view.css @@ -46,26 +46,35 @@ .aphront-list-filter-reveal { margin-left: 13%; - margin-right: 17%; - padding: 4px; + margin-right: 18%; + padding: 8px 0; overflow: hidden; - text-align: right; + text-align: center; } .device .aphront-list-filter-reveal { width: 98%; - margin-left: 0; - margin-right: 0; + margin: auto; + padding: 4px 0; } .aphront-list-filter-reveal a { font-weight: bold; + float: right; +} + +.device .aphront-list-filter-reveal a { + margin: 4px auto 0; + float: none; + display: block; } .aphront-list-filter-description { - margin-right: 20%; - color: #666666; + margin-right: 25%; float: left; + text-align: left; + line-height: 25px; + color: #666666; } .device .aphront-list-filter-description {