diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php index d1b1fcfc8e..3f04e5a62a 100644 --- a/src/applications/base/controller/PhabricatorController.php +++ b/src/applications/base/controller/PhabricatorController.php @@ -627,25 +627,4 @@ abstract class PhabricatorController extends AphrontController { return $this->delegateToController($controller); } - -/* -( Deprecated )--------------------------------------------------------- */ - - - /** - * DEPRECATED. Use @{method:newPage}. - */ - public function buildStandardPageView() { - return $this->newPage(); - } - - - /** - * DEPRECATED. Use @{method:newPage}. - */ - public function buildStandardPageResponse($view, array $data) { - $page = $this->buildStandardPageView(); - $page->appendChild($view); - return $page->produceAphrontResponse(); - } - } diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewController.php index 2ef34fb36f..3b36112a24 100644 --- a/src/applications/phpast/controller/PhabricatorXHPASTViewController.php +++ b/src/applications/phpast/controller/PhabricatorXHPASTViewController.php @@ -1,18 +1,4 @@ buildStandardPageView(); - - $page->setApplicationName('XHPASTView'); - $page->setBaseURI('/xhpast/'); - $page->setTitle(idx($data, 'title')); - $page->setGlyph("\xE2\x96\xA0"); - $page->appendChild($view); - - $response = new AphrontWebpageResponse(); - return $response->setContent($page->render()); - } - } diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php index 89f5b8fd7d..73c10cab44 100644 --- a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php +++ b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php @@ -10,17 +10,18 @@ final class PhabricatorXHPASTViewFrameController public function handleRequest(AphrontRequest $request) { $id = $request->getURIData('id'); - return $this->buildStandardPageResponse( - phutil_tag( + return $this->newPage() + ->setApplicationName('XHPASTView') + ->setBaseURI('/xhpast/') + ->setTitle(pht('XHPAST View')) + ->setGlyph("\xE2\x96\xA0") + ->appendChild(phutil_tag( 'iframe', array( 'src' => "/xhpast/frameset/{$id}/", 'frameborder' => '0', 'style' => 'width: 100%; height: 800px;', '', - )), - array( - 'title' => pht('XHPAST View'), - )); + ))); } }