From d595faf7b7bd5d424a8b2a7f3cc567c95cd3933b Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Tue, 30 Jun 2015 15:23:15 -0700
Subject: [PATCH] [Redesign] Clean up spacing on Conpherence Menu

Summary: Ref T8099. This is a little more resilient to font size changes in the main UI.

Test Plan: Change font size in settings, items grow and align correctly.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13492
---
 resources/celerity/map.php                    | 10 +++----
 .../rsrc/css/application/conpherence/menu.css | 27 +++++++++----------
 .../css/layout/phabricator-side-menu-view.css |  2 +-
 3 files changed, 19 insertions(+), 20 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 90242e4b0b..af51605f06 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '7913d525',
+    'core.pkg.css' => '53a0131b',
     'core.pkg.js' => 'a590b451',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'cf384ffa',
@@ -47,7 +47,7 @@ return array(
     'rsrc/css/application/config/setup-issue.css' => '631c4e92',
     'rsrc/css/application/config/unhandled-exception.css' => '4c96257a',
     'rsrc/css/application/conpherence/durable-column.css' => '86396117',
-    'rsrc/css/application/conpherence/menu.css' => 'f9f1d143',
+    'rsrc/css/application/conpherence/menu.css' => 'f99fee4c',
     'rsrc/css/application/conpherence/message-pane.css' => '2c16d204',
     'rsrc/css/application/conpherence/notification.css' => '6cdcc253',
     'rsrc/css/application/conpherence/transaction.css' => '85d0974c',
@@ -118,7 +118,7 @@ return array(
     'rsrc/css/font/phui-font-icon-base.css' => '3dad2ae3',
     'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82',
     'rsrc/css/layout/phabricator-hovercard-view.css' => '3a8553e7',
-    'rsrc/css/layout/phabricator-side-menu-view.css' => '8d13687d',
+    'rsrc/css/layout/phabricator-side-menu-view.css' => 'bec2458e',
     'rsrc/css/layout/phabricator-source-code-view.css' => '5e0178de',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => 'd1cf6f93',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => 'c1c7f338',
@@ -502,7 +502,7 @@ return array(
     'config-options-css' => '7fedf08b',
     'config-welcome-css' => '6abd79be',
     'conpherence-durable-column-view' => '86396117',
-    'conpherence-menu-css' => 'f9f1d143',
+    'conpherence-menu-css' => 'f99fee4c',
     'conpherence-message-pane-css' => '2c16d204',
     'conpherence-notification-css' => '6cdcc253',
     'conpherence-thread-manager' => '01774ab2',
@@ -735,7 +735,7 @@ return array(
     'phabricator-remarkup-css' => 'cb0aa7d6',
     'phabricator-search-results-css' => '7dea472c',
     'phabricator-shaped-request' => '7cbe244b',
-    'phabricator-side-menu-view-css' => '8d13687d',
+    'phabricator-side-menu-view-css' => 'bec2458e',
     'phabricator-slowvote-css' => '7c27f0f9',
     'phabricator-source-code-view-css' => '5e0178de',
     'phabricator-standard-page-view' => 'def344d6',
diff --git a/webroot/rsrc/css/application/conpherence/menu.css b/webroot/rsrc/css/application/conpherence/menu.css
index 1ee1a18372..9918b89c71 100644
--- a/webroot/rsrc/css/application/conpherence/menu.css
+++ b/webroot/rsrc/css/application/conpherence/menu.css
@@ -109,16 +109,16 @@
 
 .conpherence-menu .conpherence-menu-item-view {
   display: block;
-  height: 36px;
   overflow: hidden;
   position: relative;
   text-decoration: none;
-  border-left: 3px solid transparent;
+  border-left: 4px solid transparent;
+  padding: 4px;
 }
 
 .conpherence-menu .conpherence-selected {
   background: rgba(0,0,0,0.05);
-  border-left: 3px solid {$sky};
+  border-left: 4px solid {$sky};
 }
 
 .conpherence-menu .phui-list-item-type-link .phui-list-item-href {
@@ -127,7 +127,7 @@
 
 .device-desktop .conpherence-menu
  .conpherence-selected.conpherence-menu-item-view:hover {
-  background-color: rgba(0,0,0,0.05);
+  background-color: rgba(0,0,0,0.07);
 }
 
 .conpherence-menu .loading {
@@ -139,20 +139,19 @@
 }
 
 .conpherence-menu .conpherence-menu-item-view .conpherence-menu-item-image {
-  top: 4px;
-  left: 6px;
-  display: block;
-  position: absolute;
-  width: 24px;
-  height: 24px;
-  background-size: 24px;
-  border: 2px solid #fff;
+  width: 26px;
+  height: 26px;
+  background-size: 26px;
+  box-shadow: {$borderinset};
+  border-radius: 3px;
+  float: left;
+  margin-left: 4px;
 }
 
 .conpherence-menu .conpherence-menu-item-view .conpherence-menu-item-title {
   display: block;
-  margin-top: 9px;
-  margin-left: 40px;
+  padding: 4px 0 4px 8px;
+  float: left;
   text-align: left;
   font-weight: bold;
   font-size: {$normalfontsize};
diff --git a/webroot/rsrc/css/layout/phabricator-side-menu-view.css b/webroot/rsrc/css/layout/phabricator-side-menu-view.css
index 4c63a1b266..5a3521b17e 100644
--- a/webroot/rsrc/css/layout/phabricator-side-menu-view.css
+++ b/webroot/rsrc/css/layout/phabricator-side-menu-view.css
@@ -20,7 +20,7 @@
 
 .phabricator-side-menu .phui-list-item-selected {
   background-color: rgba(0,0,0,.05);
-  border-left: 4px solid {$blue};
+  border-left: 4px solid {$sky};
   border-top-right-radius: 3px;
   border-bottom-right-radius: 3px;
   font-weight: bold;