From d5bc8197eceb93edef943e9865a148b5ce1f6066 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 30 Oct 2013 13:06:57 -0700 Subject: [PATCH] Remove "isUnparsed" flag from commits Summary: The new "importStatus" property provides a much stronger and more consistent version of this flag. The only callsite was removed by D7452. Test Plan: Used `grep` to check for callsites and found none. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7453 --- src/applications/diffusion/query/DiffusionQuery.php | 5 ++--- .../repository/storage/PhabricatorRepositoryCommit.php | 10 ---------- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/src/applications/diffusion/query/DiffusionQuery.php b/src/applications/diffusion/query/DiffusionQuery.php index 992cc6b6d6..2b189d2266 100644 --- a/src/applications/diffusion/query/DiffusionQuery.php +++ b/src/applications/diffusion/query/DiffusionQuery.php @@ -99,8 +99,8 @@ abstract class DiffusionQuery extends PhabricatorQuery { $commits = mpull($commits, null, 'getCommitIdentifier'); // Build empty commit objects for every commit, so we can show unparsed - // commits in history views as "unparsed" instead of not showing them. This - // makes the process of importing and parsing commits much clearer to the + // commits in history views (as "Importing") instead of not showing them. + // This makes the process of importing and parsing commits clearer to the // user. $commit_list = array(); @@ -110,7 +110,6 @@ abstract class DiffusionQuery extends PhabricatorQuery { $commit_obj = new PhabricatorRepositoryCommit(); $commit_obj->setRepositoryID($repository->getID()); $commit_obj->setCommitIdentifier($identifier); - $commit_obj->setIsUnparsed(true); $commit_obj->makeEphemeral(); } $commit_list[$identifier] = $commit_obj; diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php index 55ee28dac4..d2a2518ccc 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php +++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php @@ -25,7 +25,6 @@ final class PhabricatorRepositoryCommit private $commitData = self::ATTACHABLE; private $audits; - private $isUnparsed; private $repository = self::ATTACHABLE; public function attachRepository(PhabricatorRepository $repository) { @@ -37,15 +36,6 @@ final class PhabricatorRepositoryCommit return $this->assertAttached($this->repository); } - public function setIsUnparsed($is_unparsed) { - $this->isUnparsed = $is_unparsed; - return $this; - } - - public function getIsUnparsed() { - return $this->isUnparsed; - } - public function isImported() { return ($this->getImportStatus() == self::IMPORTED_ALL); }