From d5dfa5faf5c8b5eb784c437ef2ac701269a3e6c6 Mon Sep 17 00:00:00 2001 From: tuomaspelkonen Date: Mon, 9 May 2011 17:47:12 -0700 Subject: [PATCH] Never hide file contents if they have comments. Summary: Links to comments were not working because file was hidden after it was deleted. Test Plan: Tested that comment anchors were working correctly for deleted files. Tested that generated files were still hidden. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, aran, epriestley Differential Revision: 257 --- .../parser/changeset/DifferentialChangesetParser.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/parser/changeset/DifferentialChangesetParser.php b/src/applications/differential/parser/changeset/DifferentialChangesetParser.php index 4f366bba0d..1fc45737f6 100644 --- a/src/applications/differential/parser/changeset/DifferentialChangesetParser.php +++ b/src/applications/differential/parser/changeset/DifferentialChangesetParser.php @@ -816,7 +816,7 @@ EOSYNTHETIC; } $shield = null; - if ($range_start === null && $range_len === null) { + if ($range_start === null && $range_len === null && !$this->comments) { if ($this->isGenerated()) { $shield = $this->renderShield( "This file contains generated code, which does not normally need ".