revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 20:40:56 +01:00
Code Issues Releases Wiki Activity

Allow global Commit herald rules to trigger audits by users

Browse source 
Summary: Ref T4249. Currently, a global rule can only trigger project audits. Although there probably aren't a huge number of use cases for triggering users from global rules, it works fine and it's somewhat confusing not to allow it.

Test Plan: {F90902}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4249

Differential Revision: https://secure.phabricator.com/D7803
This commit is contained in:
epriestley 2013-12-19 10:33:15 -08:00
parent 264bef58c4
commit d64dd7e2e8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/herald/adapter/HeraldAdapter.php
View file

@ -678,13 +678,13 @@ abstract class HeraldAdapter {
return self::VALUE_EMAIL; return self::VALUE_EMAIL;
case self::ACTION_NOTHING: case self::ACTION_NOTHING:
return self::VALUE_NONE; return self::VALUE_NONE;
case self::ACTION_AUDIT:
case self::ACTION_ADD_PROJECTS: case self::ACTION_ADD_PROJECTS:
return self::VALUE_PROJECT; return self::VALUE_PROJECT;
case self::ACTION_FLAG: case self::ACTION_FLAG:
return self::VALUE_FLAG_COLOR; return self::VALUE_FLAG_COLOR;
case self::ACTION_ASSIGN_TASK: case self::ACTION_ASSIGN_TASK:
return self::VALUE_USER; return self::VALUE_USER;
case self::ACTION_AUDIT:
case self::ACTION_ADD_REVIEWERS: case self::ACTION_ADD_REVIEWERS:
case self::ACTION_ADD_BLOCKING_REVIEWERS: case self::ACTION_ADD_BLOCKING_REVIEWERS:
return self::VALUE_USER_OR_PROJECT; return self::VALUE_USER_OR_PROJECT;