From d65f62d0555882c1739eba38457279e32cbf899e Mon Sep 17 00:00:00 2001 From: vrana Date: Mon, 6 Feb 2012 11:13:45 -0800 Subject: [PATCH] Use constants in DifferentialRevisionUpdateHistoryView Test Plan: Display diff with whitespace changes. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1581 --- .../DifferentialRevisionUpdateHistoryView.php | 7 ++++--- .../differential/view/revisionupdatehistory/__init__.php | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/applications/differential/view/revisionupdatehistory/DifferentialRevisionUpdateHistoryView.php b/src/applications/differential/view/revisionupdatehistory/DifferentialRevisionUpdateHistoryView.php index bdc64a6bd5..385ae8ce32 100644 --- a/src/applications/differential/view/revisionupdatehistory/DifferentialRevisionUpdateHistoryView.php +++ b/src/applications/differential/view/revisionupdatehistory/DifferentialRevisionUpdateHistoryView.php @@ -191,9 +191,10 @@ final class DifferentialRevisionUpdateHistoryView extends AphrontView { )); $options = array( - 'ignore-all' => 'Ignore Most', - 'ignore-trailing' => 'Ignore Trailing', - 'show-all' => 'Show All', + DifferentialChangesetParser::WHITESPACE_IGNORE_ALL => 'Ignore Most', + DifferentialChangesetParser::WHITESPACE_IGNORE_TRAILING => + 'Ignore Trailing', + DifferentialChangesetParser::WHITESPACE_SHOW_ALL => 'Show All', ); $select = '