revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Stop "join project" from trying to write an inverse edge on Users

Browse source 
Summary: Now that Users implement PhabricatorApplicationTransactionInterface, we try to write an inverse edge. At least for now, we should retain the old behavior instead.

Test Plan:
  - Unit tests which cover this stuff pass again.
  - Grepped for other `instanceof PhabricatorApplicationTransactionInterface`, the all seemed either benign or irrelevant.

Reviewers: joshuaspence, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D13215
This commit is contained in:
epriestley 2015-06-08 14:45:22 -07:00
parent af1b586990
commit d6afce7d30
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -2904,6 +2904,13 @@ abstract class PhabricatorApplicationTransactionEditor
continue; continue;
} }
if ($node instanceof PhabricatorUser) {
// TODO: At least for now, don't record inverse edge transactions
// for users (for example, "alincoln joined project X"): Feed fills
// this role instead.
continue;
}
$editor = $node->getApplicationTransactionEditor(); $editor = $node->getApplicationTransactionEditor();
$template = $node->getApplicationTransactionTemplate(); $template = $node->getApplicationTransactionTemplate();
$target = $node->getApplicationTransactionObject(); $target = $node->getApplicationTransactionObject();