From d6bb0d1bfa83a9a25d01dec717f149ecdd8370bb Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Thu, 7 Sep 2017 11:49:10 -0700
Subject: [PATCH] Update people edit pages UI

Summary: Updates and clarifies UI

Test Plan: New peoples, new bots, new mailing list

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18562
---
 .../PhabricatorPeopleCreateController.php         |  9 ++-------
 .../controller/PhabricatorPeopleNewController.php | 15 +++++----------
 2 files changed, 7 insertions(+), 17 deletions(-)

diff --git a/src/applications/people/controller/PhabricatorPeopleCreateController.php b/src/applications/people/controller/PhabricatorPeopleCreateController.php
index 04b2f4a8a4..c0b232645b 100644
--- a/src/applications/people/controller/PhabricatorPeopleCreateController.php
+++ b/src/applications/people/controller/PhabricatorPeopleCreateController.php
@@ -92,13 +92,9 @@ final class PhabricatorPeopleCreateController
     $crumbs->addTextCrumb($title);
     $crumbs->setBorder(true);
 
-    $header = id(new PHUIHeaderView())
-      ->setHeader($title)
-      ->setHeaderIcon('fa-user');
-
     $box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('User'))
-      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+      ->setHeaderText($title)
+      ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
       ->setForm($form);
 
     $guidance_context = new PhabricatorPeopleCreateGuidanceContext();
@@ -109,7 +105,6 @@ final class PhabricatorPeopleCreateController
       ->newInfoView();
 
     $view = id(new PHUITwoColumnView())
-      ->setHeader($header)
       ->setFooter(
         array(
           $guidance,
diff --git a/src/applications/people/controller/PhabricatorPeopleNewController.php b/src/applications/people/controller/PhabricatorPeopleNewController.php
index 60f9f47b5d..9f52cf567a 100644
--- a/src/applications/people/controller/PhabricatorPeopleNewController.php
+++ b/src/applications/people/controller/PhabricatorPeopleNewController.php
@@ -132,12 +132,15 @@ final class PhabricatorPeopleNewController
       ->setUser($admin);
 
     if ($is_bot) {
+      $title = pht('Create New Bot');
       $form->appendRemarkupInstructions(
         pht('You are creating a new **bot** user account.'));
     } else if ($is_list) {
+      $title = pht('Create New Mailing List');
       $form->appendRemarkupInstructions(
         pht('You are creating a new **mailing list** user account.'));
     } else {
+      $title = pht('Create New User');
       $form->appendRemarkupInstructions(
         pht('You are creating a new **standard** user account.'));
     }
@@ -205,25 +208,17 @@ final class PhabricatorPeopleNewController
             "`bot@yourcompany.com` if you prefer."));
     }
 
-
-    $title = pht('Create New User');
-
     $box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('User'))
+      ->setHeaderText($title)
       ->setFormErrors($errors)
-      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+      ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb($title);
     $crumbs->setBorder(true);
 
-    $header = id(new PHUIHeaderView())
-      ->setHeader($title)
-      ->setHeaderIcon('fa-user');
-
     $view = id(new PHUITwoColumnView())
-      ->setHeader($header)
       ->setFooter($box);
 
     return $this->newPage()