Add icons to Settings

Summary: Depends on D20005. I love icons.

Test Plan: {F6145996}

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20006

src/applications/conduit/settings/PhabricatorConduitTokensSettingsPanel.php

@@ -19,6 +19,10 @@ final class PhabricatorConduitTokensSettingsPanel
     return pht('Conduit API Tokens');
   }
 
+  public function getPanelMenuIcon() {
+    return id(new PhabricatorConduitApplication())->getIcon();
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsLogsPanelGroup::PANELGROUPKEY;
   }

src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php

@@ -18,6 +18,10 @@ final class DiffusionSetPasswordSettingsPanel extends PhabricatorSettingsPanel {
     return pht('VCS Password');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-code';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsAuthenticationPanelGroup::PANELGROUPKEY;
   }

src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php

@@ -11,6 +11,10 @@ final class PhabricatorOAuthServerAuthorizationsSettingsPanel
     return pht('OAuth Authorizations');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-exchange';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsLogsPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/controller/PhabricatorSettingsMainController.php

@@ -209,7 +209,11 @@ final class PhabricatorSettingsMainController
         }
       }
 
-      $nav->addFilter($panel->getPanelKey(), $panel->getPanelName());
+      $nav->addFilter(
+        $panel->getPanelKey(),
+        $panel->getPanelName(),
+        null,
+        $panel->getPanelMenuIcon());
     }
 
     return $nav;

src/applications/settings/panel/PhabricatorActivitySettingsPanel.php

@@ -10,6 +10,10 @@ final class PhabricatorActivitySettingsPanel extends PhabricatorSettingsPanel {
     return pht('Activity Logs');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-list';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsLogsPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php

@@ -9,6 +9,10 @@ final class PhabricatorConpherencePreferencesSettingsPanel
     return pht('Conpherence');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-comment-o';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsApplicationsPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorContactNumbersSettingsPanel.php

@@ -11,6 +11,10 @@ final class PhabricatorContactNumbersSettingsPanel
     return pht('Contact Numbers');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-mobile';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsAuthenticationPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php

@@ -9,6 +9,10 @@ final class PhabricatorDateTimeSettingsPanel
     return pht('Date and Time');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-calendar';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsAccountPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorDeveloperPreferencesSettingsPanel.php

@@ -9,6 +9,10 @@ final class PhabricatorDeveloperPreferencesSettingsPanel
     return pht('Developer Settings');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-magic';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsDeveloperPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php

@@ -9,6 +9,10 @@ final class PhabricatorDiffPreferencesSettingsPanel
     return pht('Diff Preferences');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-cog';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsApplicationsPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php

@@ -9,6 +9,10 @@ final class PhabricatorDisplayPreferencesSettingsPanel
     return pht('Display Preferences');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-desktop';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsApplicationsPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

@@ -11,6 +11,10 @@ final class PhabricatorEmailAddressesSettingsPanel
     return pht('Email Addresses');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-at';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsEmailPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorEmailDeliverySettingsPanel.php

@@ -9,6 +9,10 @@ final class PhabricatorEmailDeliverySettingsPanel
     return pht('Email Delivery');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-envelope-o';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsEmailPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php

@@ -9,6 +9,10 @@ final class PhabricatorEmailFormatSettingsPanel
     return pht('Email Format');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-font';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsEmailPanelGroup::PANELGROUPKEY;
   }
@@ -19,17 +23,6 @@ final class PhabricatorEmailFormatSettingsPanel
 
   public function isManagementPanel() {
     return false;
-/*
-        if (!$this->isUserPanel()) {
-      return false;
-    }
-
-    if ($this->getUser()->getIsMailingList()) {
-      return true;
-    }
-
-    return false;
-*/
   }
 
   public function isTemplatePanel() {

src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php

@@ -11,6 +11,10 @@ final class PhabricatorEmailPreferencesSettingsPanel
     return pht('Email Preferences');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-envelope-open-o';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsEmailPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php

@@ -11,6 +11,10 @@ final class PhabricatorExternalAccountsSettingsPanel
     return pht('External Accounts');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-users';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsAuthenticationPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorLanguageSettingsPanel.php

@@ -9,6 +9,10 @@ final class PhabricatorLanguageSettingsPanel
     return pht('Language');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-globe';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsAccountPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

@@ -11,6 +11,10 @@ final class PhabricatorMultiFactorSettingsPanel
     return pht('Multi-Factor Auth');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-lock';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsAuthenticationPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php

@@ -21,6 +21,10 @@ final class PhabricatorNotificationsSettingsPanel
     return pht('Notifications');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-bell-o';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsApplicationsPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

@@ -10,6 +10,10 @@ final class PhabricatorPasswordSettingsPanel extends PhabricatorSettingsPanel {
     return pht('Password');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-key';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsAuthenticationPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php

@@ -18,6 +18,10 @@ final class PhabricatorSSHKeysSettingsPanel extends PhabricatorSettingsPanel {
     return pht('SSH Public Keys');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-file-text-o';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsAuthenticationPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php

@@ -10,6 +10,10 @@ final class PhabricatorSessionsSettingsPanel extends PhabricatorSettingsPanel {
     return pht('Sessions');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-user';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsLogsPanelGroup::PANELGROUPKEY;
   }

src/applications/settings/panel/PhabricatorSettingsPanel.php

@@ -131,6 +131,16 @@ abstract class PhabricatorSettingsPanel extends Phobject {
   abstract public function getPanelName();
 
 
+  /**
+   * Return an icon for the panel in the menu.
+   *
+   * @return string Icon identifier.
+   * @task config
+   */
+  public function getPanelMenuIcon() {
+    return 'fa-wrench';
+  }
+
   /**
    * Return a panel group key constant for this panel.
    *

src/applications/settings/panel/PhabricatorTokensSettingsPanel.php

@@ -10,6 +10,10 @@ final class PhabricatorTokensSettingsPanel extends PhabricatorSettingsPanel {
     return pht('Temporary Tokens');
   }
 
+  public function getPanelMenuIcon() {
+    return 'fa-ticket';
+  }
+
   public function getPanelGroupKey() {
     return PhabricatorSettingsLogsPanelGroup::PANELGROUPKEY;
   }