mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-18 21:02:41 +01:00
Update Diff view page to new layout
Summary: Converts Diff View, single column though. Test Plan: Upload a new diff, review page. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15470
This commit is contained in:
parent
301ecdef18
commit
d76175285e
1 changed files with 20 additions and 7 deletions
|
@ -126,27 +126,40 @@ final class DifferentialDiffViewController extends DifferentialController {
|
|||
->setRenderingReferences($refs)
|
||||
->setStandaloneURI('/differential/changeset/')
|
||||
->setDiff($diff)
|
||||
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
||||
->setTitle(pht('Diff %d', $diff->getID()))
|
||||
->setUser($request->getUser());
|
||||
|
||||
$title = pht('Diff %d', $diff->getID());
|
||||
$crumbs = $this->buildApplicationCrumbs();
|
||||
$crumbs->addTextCrumb(pht('Diff %d', $diff->getID()));
|
||||
$crumbs->addTextCrumb($title);
|
||||
$crumbs->setBorder(true);
|
||||
|
||||
$header = id(new PHUIHeaderView())
|
||||
->setHeader($title);
|
||||
|
||||
$prop_box = id(new PHUIObjectBoxView())
|
||||
->setHeader($property_head)
|
||||
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
||||
->addPropertyList($property_view)
|
||||
->setForm($form);
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
array(
|
||||
$crumbs,
|
||||
$view = id(new PHUITwoColumnView())
|
||||
->setHeader($header)
|
||||
->setMainColumn(array(
|
||||
|
||||
))
|
||||
->setFooter(array(
|
||||
$prop_box,
|
||||
$table_of_contents,
|
||||
$details,
|
||||
),
|
||||
array(
|
||||
'title' => pht('Diff View'),
|
||||
));
|
||||
|
||||
$page = $this->newPage()
|
||||
->setTitle(pht('Diff View'))
|
||||
->setCrumbs($crumbs)
|
||||
->appendChild($view);
|
||||
return $page;
|
||||
}
|
||||
|
||||
private function loadSelectableRevisions(
|
||||
|
|
Loading…
Reference in a new issue