From d7c27dafd2a7ec60d32c848261b1e366d705a199 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 13 Apr 2011 12:12:02 -0700 Subject: [PATCH] Add config flags for Differential action link stuff. --- conf/default.conf.php | 9 ++++++ .../DifferentialRevisionViewController.php | 30 +++++++++++-------- 2 files changed, 26 insertions(+), 13 deletions(-) diff --git a/conf/default.conf.php b/conf/default.conf.php index 6b8a7c815d..8bbbaf9c4f 100644 --- a/conf/default.conf.php +++ b/conf/default.conf.php @@ -286,6 +286,15 @@ return array( 'text/plain' => 'text/plain; charset=utf-8', ), +// -- Differential ---------------------------------------------------------- // + + 'differential.revision-custom-detail-renderer' => null, + + +// -- Maniphest ------------------------------------------------------------- // + + 'maniphest.enabled' => true, + // -- Customization --------------------------------------------------------- // // Paths to additional phutil libraries to load. diff --git a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php index b510dd45bd..7c1a338088 100644 --- a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php @@ -360,14 +360,16 @@ class DifferentialRevisionViewController extends DifferentialController { $properties['Unit'] = $ustar.' '.$umsg.$utail; - $tasks = $revision->getAttachedPHIDs( - PhabricatorPHIDConstants::PHID_TYPE_TASK); - if ($tasks) { - $links = array(); - foreach ($tasks as $task_phid) { - $links[] = $handles[$task_phid]->renderLink(); + if (PhabricatorEnv::getEnvConfig('maniphest.enabled')) { + $tasks = $revision->getAttachedPHIDs( + PhabricatorPHIDConstants::PHID_TYPE_TASK); + if ($tasks) { + $links = array(); + foreach ($tasks as $task_phid) { + $links[] = $handles[$task_phid]->renderLink(); + } + $properties['Maniphest Tasks'] = implode('
', $links); } - $properties['Maniphest Tasks'] = implode('
', $links); } $commit_phids = $revision->getCommitPHIDs(); @@ -419,12 +421,14 @@ class DifferentialRevisionViewController extends DifferentialController { require_celerity_resource('phabricator-object-selector-css'); require_celerity_resource('javelin-behavior-phabricator-object-selector'); - $links[] = array( - 'class' => 'attach-maniphest', - 'name' => 'Edit Maniphest Tasks', - 'href' => "/differential/attach/{$revision_id}/TASK/", - 'sigil' => 'workflow', - ); + if (PhabricatorEnv::getEnvConfig('maniphest.enabled')) { + $links[] = array( + 'class' => 'attach-maniphest', + 'name' => 'Edit Maniphest Tasks', + 'href' => "/differential/attach/{$revision_id}/TASK/", + 'sigil' => 'workflow', + ); + } $links[] = array( 'class' => 'transcripts-metamta',