revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Update diff changeset icons

Browse source 
Summary: Fix size and spacing of file icons in diffs, update with new types, consistency.

Test Plan: Tested a diff in differential

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9372
This commit is contained in:
Chad Little 2014-06-04 12:53:07 -07:00
parent 40e2a1c800
commit d7ffe97857
3 changed files with 25 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -10,7 +10,7 @@ return array(
'core.pkg.css' => '2920014c', 'core.pkg.css' => '2920014c',
'core.pkg.js' => '639b2433', 'core.pkg.js' => '639b2433',
'darkconsole.pkg.js' => 'ca8671ce', 'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => 'fbf57382', 'differential.pkg.css' => '4a93db37',
'differential.pkg.js' => 'eca39a2c', 'differential.pkg.js' => 'eca39a2c',
'diffusion.pkg.css' => '3783278d', 'diffusion.pkg.css' => '3783278d',
'diffusion.pkg.js' => '077e3ad0', 'diffusion.pkg.js' => '077e3ad0',
@ -54,7 +54,7 @@ return array(
'rsrc/css/application/dashboard/dashboard.css' => 'f593f8c2', 'rsrc/css/application/dashboard/dashboard.css' => 'f593f8c2',
'rsrc/css/application/diff/inline-comment-summary.css' => '8cfd34e8', 'rsrc/css/application/diff/inline-comment-summary.css' => '8cfd34e8',
'rsrc/css/application/differential/add-comment.css' => 'c478bcaa', 'rsrc/css/application/differential/add-comment.css' => 'c478bcaa',
'rsrc/css/application/differential/changeset-view.css' => 'f234b888', 'rsrc/css/application/differential/changeset-view.css' => 'ff8eacf8',
'rsrc/css/application/differential/core.css' => '7ac3cabc', 'rsrc/css/application/differential/core.css' => '7ac3cabc',
'rsrc/css/application/differential/results-table.css' => '239924f9', 'rsrc/css/application/differential/results-table.css' => '239924f9',
'rsrc/css/application/differential/revision-comment.css' => '48186045', 'rsrc/css/application/differential/revision-comment.css' => '48186045',
@ -510,7 +510,7 @@ return array(
'conpherence-notification-css' => '04a6e10a', 'conpherence-notification-css' => '04a6e10a',
'conpherence-update-css' => '1099a660', 'conpherence-update-css' => '1099a660',
'conpherence-widget-pane-css' => 'bf275a6c', 'conpherence-widget-pane-css' => 'bf275a6c',
'differential-changeset-view-css' => 'f234b888', 'differential-changeset-view-css' => 'ff8eacf8',
'differential-core-view-css' => '7ac3cabc', 'differential-core-view-css' => '7ac3cabc',
'differential-inline-comment-editor' => 'f2441746', 'differential-inline-comment-editor' => 'f2441746',
'differential-results-table-css' => '239924f9', 'differential-results-table-css' => '239924f9',

27
src/applications/differential/view/DifferentialChangesetDetailView.php
View file

@ -104,16 +104,19 @@ final class DifferentialChangesetDetailView extends AphrontView {
case 'wav': case 'wav':
case 'mp3': case 'mp3':
case 'aiff': case 'aiff':
$icon = 'fa-music'; $icon = 'fa-file-sound-o';
break; break;
case 'm4v': case 'm4v':
case 'mov': case 'mov':
$icon = 'fa-film'; $icon = 'fa-file-movie-o';
break; break;
case 'sql'; case 'sql':
case 'db': case 'db':
$icon = 'fa-database';
break;
case 'xls':
case 'csv': case 'csv':
$icon = 'fa-table'; $icon = 'fa-file-excel-o';
break; break;
case 'ics': case 'ics':
$icon = 'fa-calendar'; $icon = 'fa-calendar';
@ -123,16 +126,26 @@ final class DifferentialChangesetDetailView extends AphrontView {
case 'bz': case 'bz':
case 'tgz': case 'tgz':
case 'gz': case 'gz':
$icon = 'fa-archive'; $icon = 'fa-file-archive-o';
break; break;
case 'png': case 'png':
case 'jpg': case 'jpg':
case 'bmp': case 'bmp':
case 'gif': case 'gif':
$icon = 'fa-picture-o'; $icon = 'fa-file-picture-o';
break;
case 'txt':
$icon = 'fa-file-text-o';
break;
case 'doc':
case 'docx':
$icon = 'fa-file-word-o';
break;
case 'pdf':
$icon = 'fa-file-pdf-o';
break; break;
default: default:
$icon = 'fa-file'; $icon = 'fa-file-code-o';
break; break;
} }
return $icon; return $icon;

3
webroot/rsrc/css/application/differential/changeset-view.css
View file

@ -470,8 +470,9 @@ tr.differential-inline-loading {
.differential-file-icon-header .phui-icon-view { .differential-file-icon-header .phui-icon-view {
display: inline-block; display: inline-block;
margin: 0 4px 2px 0; margin: 0 6px 2px 0;
vertical-align: middle; vertical-align: middle;
font-size: 14px;
} }
.device-phone .differential-file-icon-header .phui-icon-view { .device-phone .differential-file-icon-header .phui-icon-view {