From d816ac0b01d70632f494d536a6e453fddf4707ab Mon Sep 17 00:00:00 2001 From: lkassianik Date: Tue, 28 Apr 2015 08:56:00 -0700 Subject: [PATCH] Fixing some calendar event timeline issues. Summary: Ref T7953, Fixing some calendar event timeline issues. Test Plan: Create event, event timeline should reflect the transaction. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7953 Differential Revision: https://secure.phabricator.com/D12592 --- .../controller/PhabricatorCalendarEventViewController.php | 4 ---- .../storage/PhabricatorCalendarEventTransaction.php | 7 +++++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php b/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php index 0cf3d7401b..8531ab9236 100644 --- a/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php +++ b/src/applications/calendar/controller/PhabricatorCalendarEventViewController.php @@ -102,10 +102,6 @@ final class PhabricatorCalendarEventViewController ->setUser($viewer) ->setObject($event); - // $properties->addProperty( - // pht('Name'), - // $event->getName()); - $properties->addProperty( pht('Starts'), phabricator_datetime($event->getDateFrom(), $viewer)); diff --git a/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php b/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php index c17bf0905f..fb7564bdc1 100644 --- a/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php +++ b/src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php @@ -43,7 +43,6 @@ final class PhabricatorCalendarEventTransaction public function shouldHide() { $old = $this->getOldValue(); switch ($this->getTransactionType()) { - case self::TYPE_NAME: case self::TYPE_START_DATE: case self::TYPE_END_DATE: case self::TYPE_STATUS: @@ -76,7 +75,11 @@ final class PhabricatorCalendarEventTransaction $type = $this->getTransactionType(); switch ($type) { case self::TYPE_NAME: - if ($old) { + if ($old === null) { + return pht( + '%s created this event.', + $this->renderHandleLink($author_phid)); + } else { return pht( '%s changed the name of this event from %s to %s.', $this->renderHandleLink($author_phid),