Hide Search text better

Summary: Previously, this text was transparent, moved it to a new span and set visibility on it.

Test Plan: review search in FF, Chrome. Text no longer displays.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7710

Differential Revision: https://secure.phabricator.com/D12219

resources/celerity/map.php

@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '20d3b672',
+    'core.pkg.css' => '6088c5b0',
     'core.pkg.js' => '0c88e7f6',
     'darkconsole.pkg.js' => '8ab24e01',
     'differential.pkg.css' => '3500921f',
@@ -34,7 +34,7 @@ return array(
     'rsrc/css/aphront/typeahead.css' => '0e403212',
     'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af',
     'rsrc/css/application/auth/auth.css' => '1e655982',
-    'rsrc/css/application/base/main-menu-view.css' => 'cfa2ec0f',
+    'rsrc/css/application/base/main-menu-view.css' => '361a51f9',
     'rsrc/css/application/base/notification-menu.css' => '6aa0a74b',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
     'rsrc/css/application/base/standard-page-view.css' => 'd2a6518d',
@@ -729,7 +729,7 @@ return array(
     'phabricator-hovercard-view-css' => '893f4783',
     'phabricator-keyboard-shortcut' => '1ae869f2',
     'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
-    'phabricator-main-menu-view' => 'cfa2ec0f',
+    'phabricator-main-menu-view' => '361a51f9',
     'phabricator-nav-view-css' => '7aeaf435',
     'phabricator-notification' => '0c6946e7',
     'phabricator-notification-css' => '9c279160',

src/view/page/menu/PhabricatorMainMenuSearchView.php

@@ -56,6 +56,13 @@ final class PhabricatorMainMenuSearchView extends AphrontView {
         'value' => 'true',
       ));
 
+    $search_text = javelin_tag(
+      'span',
+      array(
+        'aural' => true,
+      ),
+      pht('Search'));
+
     $form = phabricator_form(
       $user,
       array(
@@ -70,7 +77,7 @@ final class PhabricatorMainMenuSearchView extends AphrontView {
             'id' => $button_id,
             'class' => 'phui-icon-view phui-font-fa fa-search lightgreytext',
             ),
-          pht('Search')),
+          $search_text),
         $primary_input,
         $target,
       )));

webroot/rsrc/css/application/base/main-menu-view.css

@@ -189,9 +189,10 @@
   min-width: 0;
 
   height: 24px;
-  width: 24px;
+  width: 16px;
   top: 10px;
   right: 10px;
+  padding: 0;
 }
 
 .device .phabricator-main-menu-search button {