revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Use authoritative user identity for revision author

Browse source 
Summary: We added a proper way to get the authoritative user a while ago, this
method just never got switched to use it.
Test Plan: Created a revision locally, was recognized as the revision author.
Reviewed By: jungejason
Reviewers: gc3, jungejason, tuomaspelkonen, aran
CC: aran, jungejason
Differential Revision: 566
This commit is contained in:
epriestley 2011-06-30 13:58:28 -07:00
parent 2b8116d7ae
commit d92f303e0c
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/conduit/method/differential/createrevision/ConduitAPI_differential_createrevision_Method.php
View file

@ -26,7 +26,6 @@ class ConduitAPI_differential_createrevision_Method extends ConduitAPIMethod {
return array( return array(
'diffid' => 'required diffid', 'diffid' => 'required diffid',
'fields' => 'required dict', 'fields' => 'required dict',
'user' => 'required guid',
); );
} }
@ -51,7 +50,7 @@ class ConduitAPI_differential_createrevision_Method extends ConduitAPIMethod {
$revision = DifferentialRevisionEditor::newRevisionFromConduitWithDiff( $revision = DifferentialRevisionEditor::newRevisionFromConduitWithDiff(
$fields, $fields,
$diff, $diff,
$request->getValue('user')); // TODO: Should be authoritative $request->getUser()->getPHID());
return array( return array(
'revisionid' => $revision->getID(), 'revisionid' => $revision->getID(),