revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine

Browse source 
Summary:
The commit rP7bde92b9c9806c5967df617fb4e843dea315ecf7 (2016) introduced `private function validateNavigationMenuItem()`.
The only call to this method was removed in rP950e9d085b482bc3484e2066591ac07c20154c9a.
Thus remove this unused method.

Test Plan:
Read/grep the code in `PhabricatorProfileMenuEngine`.

Run also `grep -RF 'validateNavigationMenuItem' --include="*.php" .` to verify that this is an orphan method.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25719
This commit is contained in:
Andre Klapper 2024-07-02 22:52:37 +02:00
parent ff7be2cf14
commit d9592e0348
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/search/engine/PhabricatorProfileMenuEngine.php
View file

@ -469,15 +469,6 @@ abstract class PhabricatorProfileMenuEngine extends Phobject {
return $map;
}
private function validateNavigationMenuItem($item) {
if (!($item instanceof PHUIListItemView)) {
throw new Exception(
pht(
'Expected buildNavigationMenuItems() to return a list of '.
'PHUIListItemView objects, but got a surprise.'));
}
}
public function getConfigureURI() {
$mode = $this->getEditMode();