From da1e711abbf5296862256dfe120157bafc59bdd9 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sat, 8 Aug 2015 07:43:08 -0700
Subject: [PATCH] Hide skipped tests by default in Differential build result
 summary view

Summary: Ref T8096. Currently, we hide passing tests by default (they aren't interesting) but should also hide skipped tests by default (they aren't interesting either).

Test Plan: {F694485}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8096

Differential Revision: https://secure.phabricator.com/D13821
---
 .../differential/customfield/DifferentialUnitField.php | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/applications/differential/customfield/DifferentialUnitField.php b/src/applications/differential/customfield/DifferentialUnitField.php
index daff8cf0d5..b5de9fce53 100644
--- a/src/applications/differential/customfield/DifferentialUnitField.php
+++ b/src/applications/differential/customfield/DifferentialUnitField.php
@@ -56,8 +56,14 @@ final class DifferentialUnitField
 
   protected function newHarbormasterMessageView(array $messages) {
     foreach ($messages as $key => $message) {
-      if ($message->getResult() == ArcanistUnitTestResult::RESULT_PASS) {
-        unset($messages[$key]);
+      switch ($message->getResult()) {
+        case ArcanistUnitTestResult::RESULT_PASS:
+        case ArcanistUnitTestResult::RESULT_SKIP:
+          // Don't show "Pass" or "Skip" in the UI since they aren't very
+          // interesting. The user can click through to the full results if
+          // they want details.
+          unset($messages[$key]);
+          break;
       }
     }