From da1ed2c63ac9b45c34fec4f14c178bd4f2a9fc0f Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Sun, 2 Oct 2016 20:09:43 -0700
Subject: [PATCH] Don't mark a thread as seen if durable column is minimized

Summary: More work to do here on the JS side, but this at least makes sure users with a small chat window have some notification marked that new replies have not been seen.

Test Plan: Open two windows. Window 1 has durable minimized, Window 2 is full conpherence. Send a message from Window 2, see header count in Window 1 increase. Repeat with durable open, see no change in window.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D16650
---
 .../controller/ConpherenceUpdateController.php           | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/applications/conpherence/controller/ConpherenceUpdateController.php b/src/applications/conpherence/controller/ConpherenceUpdateController.php
index 5a1ad4e8fa..dbcd02e50e 100644
--- a/src/applications/conpherence/controller/ConpherenceUpdateController.php
+++ b/src/applications/conpherence/controller/ConpherenceUpdateController.php
@@ -607,8 +607,13 @@ final class ConpherenceUpdateController
         $user,
         $conpherence,
         !$minimal_display);
-      $participant_obj = $conpherence->getParticipant($user->getPHID());
-      $participant_obj->markUpToDate($conpherence, $data['latest_transaction']);
+      $key = PhabricatorConpherenceColumnMinimizeSetting::SETTINGKEY;
+      $minimized = $user->getUserSetting($key);
+      if (!$minimized) {
+        $participant_obj = $conpherence->getParticipant($user->getPHID());
+        $participant_obj
+          ->markUpToDate($conpherence, $data['latest_transaction']);
+      }
     } else if ($need_transactions) {
       $non_update = true;
       $data = array();