From da4617aabd3fde757335a5149eabcba8239724ae Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Mon, 18 May 2015 14:10:47 -0700 Subject: [PATCH] Conpherence - fix widget updates from main view Summary: Fixes T8217. Broken circa D12760. Some browsers rendered nothing while others rendered a ",". Test Plan: added folks to conpherences and saw people widget update correctly. added files to conpherence and saw file widget update correctly. Tested on Chrome and Firefox. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8217 Differential Revision: https://secure.phabricator.com/D12912 --- .../conpherence/controller/ConpherenceUpdateController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/conpherence/controller/ConpherenceUpdateController.php b/src/applications/conpherence/controller/ConpherenceUpdateController.php index eea1d1dc8a..d37fefdf14 100644 --- a/src/applications/conpherence/controller/ConpherenceUpdateController.php +++ b/src/applications/conpherence/controller/ConpherenceUpdateController.php @@ -528,14 +528,14 @@ final class ConpherenceUpdateController ->setUser($this->getRequest()->getUser()) ->setConpherence($conpherence) ->setUpdateURI($widget_uri); - $file_widget = $file_widget->render(); + $file_widget = hsprintf('%s', $file_widget->render()); break; case ConpherenceUpdateActions::ADD_PERSON: $people_widget = id(new ConpherencePeopleWidgetView()) ->setUser($user) ->setConpherence($conpherence) ->setUpdateURI($widget_uri); - $people_widget = $people_widget->render(); + $people_widget = hsprintf('%s', $people_widget->render()); break; case ConpherenceUpdateActions::REMOVE_PERSON: case ConpherenceUpdateActions::NOTIFICATIONS: