Calendar event detail view should show no time for all day events, and should show only one time field for one day events.

Summary: Ref T8021, Calendar event detail view should show no time for all day events, and should show only one time field for one day events

Test Plan: Open all-day event, event should show "Time" field with not start/end dates. Two day events should show start and end days, not times. Normal events should show old way of displaying start and end times.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8021

Differential Revision: https://secure.phabricator.com/D12768

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

@@ -179,13 +179,31 @@ final class PhabricatorCalendarEventViewController
       ->setUser($viewer)
       ->setObject($event);
 
-    $properties->addProperty(
+    if ($event->getIsAllDay()) {
-      pht('Starts'),
+      $date_start = phabricator_date($event->getDateFrom(), $viewer);
-      phabricator_datetime($event->getDateFrom(), $viewer));
+      $date_end = phabricator_date($event->getDateTo(), $viewer);
 
-    $properties->addProperty(
+      if ($date_start == $date_end) {
-      pht('Ends'),
+        $properties->addProperty(
-      phabricator_datetime($event->getDateTo(), $viewer));
+          pht('Time'),
+          phabricator_date($event->getDateFrom(), $viewer));
+      } else {
+        $properties->addProperty(
+          pht('Starts'),
+          phabricator_date($event->getDateFrom(), $viewer));
+        $properties->addProperty(
+          pht('Ends'),
+          phabricator_date($event->getDateTo(), $viewer));
+      }
+    } else {
+      $properties->addProperty(
+        pht('Starts'),
+        phabricator_datetime($event->getDateFrom(), $viewer));
+
+      $properties->addProperty(
+        pht('Ends'),
+        phabricator_datetime($event->getDateTo(), $viewer));
+    }
 
     $properties->addProperty(
       pht('Host'),