revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 05:20:56 +01:00
Code Issues Releases Wiki Activity

Use AphrontFormLayoutView, not AphrontFormView, for GitHub 'Repository'

Browse source 
interface

Summary:
See T58. When I originally wrote this interface you couldn't make a form that
looked like a form but wasn't really a form, so I made it a real form. That
meant you could hit "return" in the text input and submit the form, which didn't
do anything but is vaguely silly.

After D422 there's a layout-only form element, so switch to that.

Test Plan: Loaded the tab, hit return in the textarea, it didn't do a form
submit.
Reviewed By: jungejason
Reviewers: jungejason, tuomaspelkonen, aran
CC: aran, jungejason, epriestley
Differential Revision: 719
This commit is contained in:
epriestley 2011-07-24 12:28:51 -07:00
parent 6e08a9215d
commit da8beefa6c
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/repository/controller/edit/PhabricatorRepositoryEditController.php
View file

@ -508,7 +508,6 @@ class PhabricatorRepositoryEditController
private function processGithubRequest() { private function processGithubRequest() {
$request = $this->getRequest(); $request = $this->getRequest();
$user = $request->getUser();
$repository = $this->repository; $repository = $this->repository;
$repository_id = $repository->getID(); $repository_id = $repository->getID();
@ -516,9 +515,10 @@ class PhabricatorRepositoryEditController
$path = '/github-post-receive/'.$repository_id.'/'.$token.'/'; $path = '/github-post-receive/'.$repository_id.'/'.$token.'/';
$post_uri = PhabricatorEnv::getURI($path); $post_uri = PhabricatorEnv::getURI($path);
$gitform = new AphrontFormView(); $gitform = new AphrontFormLayoutView();
$gitform $gitform
->setUser($user) ->setBackgroundShading(true)
->setPadded(true)
->appendChild( ->appendChild(
'<p class="aphront-form-instructions">You can configure GitHub to '. '<p class="aphront-form-instructions">You can configure GitHub to '.
'notify Phabricator after changes are pushed. Log into GitHub, go '. 'notify Phabricator after changes are pushed. Log into GitHub, go '.

1
src/applications/repository/controller/edit/__init__.php
View file

@ -22,6 +22,7 @@ phutil_require_module('phabricator', 'view/form/control/submit');
phutil_require_module('phabricator', 'view/form/control/text'); phutil_require_module('phabricator', 'view/form/control/text');
phutil_require_module('phabricator', 'view/form/control/textarea'); phutil_require_module('phabricator', 'view/form/control/textarea');
phutil_require_module('phabricator', 'view/form/error'); phutil_require_module('phabricator', 'view/form/error');
phutil_require_module('phabricator', 'view/form/layout');
phutil_require_module('phabricator', 'view/layout/panel'); phutil_require_module('phabricator', 'view/layout/panel');
phutil_require_module('phabricator', 'view/layout/sidenav'); phutil_require_module('phabricator', 'view/layout/sidenav');
phutil_require_module('phabricator', 'view/utils'); phutil_require_module('phabricator', 'view/utils');