revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
Code Issues Releases Wiki Activity

Don't synchronize Asana objects with no CCs and no responsible, non-author users

Browse source 
Summary: Ref T2852. Currently, we publish commits with no audit requests and reviews with no CCs or reviewers into Asana. This creates undesired notifications, so drop events which would publish an object that doesn't exist yet and has no followers or respible users.

Test Plan: Used `bin/feed republish` to publish a story about an object with no related users, saw the publish abort with the new message. Added a CC, published again, got a publish.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6727
This commit is contained in:
epriestley 2013-08-12 11:20:30 -07:00
parent a0f0ba6acd
commit da8ffbac12
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/doorkeeper/worker/DoorkeeperFeedWorkerAsana.php
View file

@ -283,6 +283,14 @@ final class DoorkeeperFeedWorkerAsana extends FeedPushWorker {
}
}
} else {
// If there are no followers (CCs), and no active or passive users
// (reviewers or auditors), and we haven't synchronized the object before,
// don't synchronize the object.
if (!$active_phids && !$passive_phids && !$follow_phids) {
$this->log("Object has no followers or active/passive users.\n");
return;
}
$parent = $this->makeAsanaAPICall(
$oauth_token,
'tasks',