revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
Code Issues Releases Wiki Activity

Add a missing (string) cast to repository.query

Browse source 
Summary: The method returns a PhutilURI object, which json_encode() encodes as "{}" since all the properties are private.

Test Plan:
Examined the output of "repository.query" more carefully:

  "0" : {
    "name"      : "Phabricator",
    "callsign"  : "P",
    "vcs"       : "git",
    "uri"       : "http:\/\/local.aphront.com:8080\/diffusion\/P\/",
    "remoteURI" : "git:\/\/github.com\/facebook\/phabricator.git",
    "tracking"  : true
  },

Reviewers: csilvers, btrahan, vrana, jungejason

Reviewed By: csilvers

CC: aran

Differential Revision: https://secure.phabricator.com/D2402
This commit is contained in:
epriestley 2012-05-04 17:08:42 -07:00
parent a122336b3e
commit db20c74044
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/conduit/method/repository/base/ConduitAPI_repository_Method.php
View file

@ -27,7 +27,7 @@ abstract class ConduitAPI_repository_Method extends ConduitAPIMethod {
'callsign' => $repository->getCallsign(), 'callsign' => $repository->getCallsign(),
'vcs' => $repository->getVersionControlSystem(), 'vcs' => $repository->getVersionControlSystem(),
'uri' => PhabricatorEnv::getProductionURI($repository->getURI()), 'uri' => PhabricatorEnv::getProductionURI($repository->getURI()),
'remoteURI' => $repository->getPublicRemoteURI(), 'remoteURI' => (string)$repository->getPublicRemoteURI(),
'tracking' => $repository->getDetail('tracking-enabled'), 'tracking' => $repository->getDetail('tracking-enabled'),
); );
} }