revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-05 20:31:03 +01:00
Code Issues Releases Wiki Activity

(stable) Write edge transactions in a more compact way

Browse source 
Summary: Depends on D18946. Ref T13051. Begins writing edge transactions as just a list of changed PHIDs.

Test Plan: Added, edited, and removed projects. Reviewed transaction record and database. Saw no user-facing changes but a far more compact database representation.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13051

Differential Revision: https://secure.phabricator.com/D18947
This commit is contained in:
epriestley 2018-01-27 05:54:21 -08:00
parent 207131d14f
commit db8ba29925
2 changed files with 50 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -999,7 +999,31 @@ abstract class PhabricatorApplicationTransactionEditor
$xaction->setPHID($xaction->generatePHID()); $xaction->setPHID($xaction->generatePHID());
$comment_editor->applyEdit($xaction, $xaction->getComment()); $comment_editor->applyEdit($xaction, $xaction->getComment());
} else { } else {
$xaction->save();
// TODO: This is a transitional hack to let us migrate edge
// transactions to a more efficient storage format. For now, we're
// going to write a new slim format to the database but keep the old
// bulky format on the objects so we don't have to upgrade all the
// edit logic to the new format yet. See T13051.
$edge_type = PhabricatorTransactions::TYPE_EDGE;
if ($xaction->getTransactionType() == $edge_type) {
$bulky_old = $xaction->getOldValue();
$bulky_new = $xaction->getNewValue();
$record = PhabricatorEdgeChangeRecord::newFromTransaction($xaction);
$slim_old = $record->getModernOldEdgeTransactionData();
$slim_new = $record->getModernNewEdgeTransactionData();
$xaction->setOldValue($slim_old);
$xaction->setNewValue($slim_new);
$xaction->save();
$xaction->setOldValue($bulky_old);
$xaction->setNewValue($bulky_new);
} else {
$xaction->save();
}
} }
} }

27
src/infrastructure/edges/util/PhabricatorEdgeChangeRecord.php
View file

@ -44,10 +44,18 @@ final class PhabricatorEdgeChangeRecord
return array_keys($rem); return array_keys($rem);
} }
public function getModernOldEdgeTransactionData() {
return $this->getRemovedPHIDs();
}
public function getModernNewEdgeTransactionData() {
return $this->getAddedPHIDs();
}
private function getOldDestinationPHIDs() { private function getOldDestinationPHIDs() {
if ($this->xaction) { if ($this->xaction) {
$old = $this->xaction->getOldValue(); $old = $this->xaction->getOldValue();
return ipull($old, 'dst'); return $this->getPHIDsFromTransactionValue($old);
} }
throw new Exception( throw new Exception(
@ -57,12 +65,27 @@ final class PhabricatorEdgeChangeRecord
private function getNewDestinationPHIDs() { private function getNewDestinationPHIDs() {
if ($this->xaction) { if ($this->xaction) {
$new = $this->xaction->getNewValue(); $new = $this->xaction->getNewValue();
return ipull($new, 'dst'); return $this->getPHIDsFromTransactionValue($new);
} }
throw new Exception( throw new Exception(
pht('Edge change record is not configured with any change data.')); pht('Edge change record is not configured with any change data.'));
} }
private function getPHIDsFromTransactionValue($value) {
if (!$value) {
return array();
}
// If the list items are arrays, this is an older-style map of
// dictionaries.
$head = head($value);
if (is_array($head)) {
return ipull($value, 'dst');
}
// If the list items are not arrays, this is a newer-style list of PHIDs.
return $value;
}
} }