revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Unprototype "Draft" mode in Differential

Browse source 
Summary: Fixes T2543. This mode has been a stable prototype for a very long time now; promote it so "--draft" can promote out of "experimental" in Arcanist.

Test Plan: See T2543 for discussion.

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D20983
This commit is contained in:
epriestley 2020-02-12 15:47:09 -08:00
parent 35a18146a2
commit dc35ce79e4
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/differential/storage/DifferentialRevision.php
View file

@ -73,13 +73,8 @@ final class DifferentialRevision extends DifferentialDAO
$view_policy = $app->getPolicy( $view_policy = $app->getPolicy(
DifferentialDefaultViewCapability::CAPABILITY); DifferentialDefaultViewCapability::CAPABILITY);
if (PhabricatorEnv::getEnvConfig('phabricator.show-prototypes')) { $initial_state = DifferentialRevisionStatus::DRAFT;
$initial_state = DifferentialRevisionStatus::DRAFT; $should_broadcast = false;
$should_broadcast = false;
} else {
$initial_state = DifferentialRevisionStatus::NEEDS_REVIEW;
$should_broadcast = true;
}
return id(new DifferentialRevision()) return id(new DifferentialRevision())
->setViewPolicy($view_policy) ->setViewPolicy($view_policy)