revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
Code Issues Releases Wiki Activity

Simplify default field loadout for Differential

Browse source 
Summary:
Remove the blame revision, revert plan and lines fields from the default field
loadout. (After D829 this doesn't cause issues where we have bogus dictionary
entries.)

You should add these back to the Facebook configuration since Facebook wants
these fields. However, I want to keep the default stack very light and I never
saw a huge amount of value in these fields at Facebook so I don't think they
make the cut. Sorry, tomo. ;_;

Test Plan: Ran "arc diff" locally.

Reviewers: jungejason, tuomaspelkonen, aran

Reviewed By: aran

CC: aran, tomo, epriestley

Differential Revision: 831
This commit is contained in:
epriestley 2011-08-18 12:35:58 -07:00
parent ebdd6d3d11
commit dc39571d63
2 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/differential/field/selector/default/DifferentialDefaultFieldSelector.php
View file

@ -36,19 +36,11 @@ final class DifferentialDefaultFieldSelector
new DifferentialManiphestTasksFieldSpecification(), new DifferentialManiphestTasksFieldSpecification(),
new DifferentialHostFieldSpecification(), new DifferentialHostFieldSpecification(),
new DifferentialPathFieldSpecification(), new DifferentialPathFieldSpecification(),
new DifferentialLinesFieldSpecification(),
new DifferentialArcanistProjectFieldSpecification(), new DifferentialArcanistProjectFieldSpecification(),
new DifferentialApplyPatchFieldSpecification(), new DifferentialApplyPatchFieldSpecification(),
new DifferentialExportPatchFieldSpecification(), new DifferentialExportPatchFieldSpecification(),
new DifferentialRevisionIDFieldSpecification(), new DifferentialRevisionIDFieldSpecification(),
new DifferentialGitSVNIDFieldSpecification(), new DifferentialGitSVNIDFieldSpecification(),
// TODO: Remove these from the default set, we need them temporarily
// because the commit message dictionary always contains their keys
// right now.
new DifferentialBlameRevisionFieldSpecification(),
new DifferentialRevertPlanFieldSpecification(),
); );
} }

3
src/applications/differential/field/selector/default/__init__.php
View file

@ -10,18 +10,15 @@ phutil_require_module('phabricator', 'applications/differential/field/selector/b
phutil_require_module('phabricator', 'applications/differential/field/specification/applypatch'); phutil_require_module('phabricator', 'applications/differential/field/specification/applypatch');
phutil_require_module('phabricator', 'applications/differential/field/specification/arcanistproject'); phutil_require_module('phabricator', 'applications/differential/field/specification/arcanistproject');
phutil_require_module('phabricator', 'applications/differential/field/specification/author'); phutil_require_module('phabricator', 'applications/differential/field/specification/author');
phutil_require_module('phabricator', 'applications/differential/field/specification/blamerev');
phutil_require_module('phabricator', 'applications/differential/field/specification/ccs'); phutil_require_module('phabricator', 'applications/differential/field/specification/ccs');
phutil_require_module('phabricator', 'applications/differential/field/specification/commits'); phutil_require_module('phabricator', 'applications/differential/field/specification/commits');
phutil_require_module('phabricator', 'applications/differential/field/specification/dependencies'); phutil_require_module('phabricator', 'applications/differential/field/specification/dependencies');
phutil_require_module('phabricator', 'applications/differential/field/specification/exportpatch'); phutil_require_module('phabricator', 'applications/differential/field/specification/exportpatch');
phutil_require_module('phabricator', 'applications/differential/field/specification/gitsvnid'); phutil_require_module('phabricator', 'applications/differential/field/specification/gitsvnid');
phutil_require_module('phabricator', 'applications/differential/field/specification/host'); phutil_require_module('phabricator', 'applications/differential/field/specification/host');
phutil_require_module('phabricator', 'applications/differential/field/specification/lines');
phutil_require_module('phabricator', 'applications/differential/field/specification/lint'); phutil_require_module('phabricator', 'applications/differential/field/specification/lint');
phutil_require_module('phabricator', 'applications/differential/field/specification/maniphesttasks'); phutil_require_module('phabricator', 'applications/differential/field/specification/maniphesttasks');
phutil_require_module('phabricator', 'applications/differential/field/specification/path'); phutil_require_module('phabricator', 'applications/differential/field/specification/path');
phutil_require_module('phabricator', 'applications/differential/field/specification/revertplan');
phutil_require_module('phabricator', 'applications/differential/field/specification/reviewedby'); phutil_require_module('phabricator', 'applications/differential/field/specification/reviewedby');
phutil_require_module('phabricator', 'applications/differential/field/specification/reviewers'); phutil_require_module('phabricator', 'applications/differential/field/specification/reviewers');
phutil_require_module('phabricator', 'applications/differential/field/specification/revisionid'); phutil_require_module('phabricator', 'applications/differential/field/specification/revisionid');