From dc62d18b473624a2547efb5751f2713ce0047256 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 27 Nov 2017 17:34:43 -0800 Subject: [PATCH] Allow MFA enrollment before email verification Summary: Depends on D18791. Ref T13024. This clears up another initialization order issue, where an unverified address could prevent MFA enrollment. Test Plan: Configured both verification required and MFA required, clicked "Add Factor", got a dialog for the workflow. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13024 Differential Revision: https://secure.phabricator.com/D18792 --- .../PhabricatorAuthNeedsMultiFactorController.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php b/src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php index d295812d3e..27e03485ca 100644 --- a/src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php +++ b/src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php @@ -15,6 +15,12 @@ final class PhabricatorAuthNeedsMultiFactorController return false; } + public function shouldRequireEmailVerification() { + // Users who haven't verified their email addresses yet can still enroll + // in MFA. + return false; + } + public function handleRequest(AphrontRequest $request) { $viewer = $this->getViewer();