From dce6d2e9d58d85dde9c3e9fa9850c54bc7e671f0 Mon Sep 17 00:00:00 2001
From: Ricky Elrod <ricky@elrod.me>
Date: Mon, 21 Jan 2013 18:41:38 -0800
Subject: [PATCH] Make the 'Subscribe' button pop a modal instead.

Summary:
See title.

Also some minor styling/consistency fixes.

Test Plan:
- Clicked subscribe
- Canceled to make sure it went away
- Clicked it again
- Clicked subscribe
- Saw my name in the cc field.

Reviewers: epriestley, chad, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4571
---
 .../DifferentialRevisionViewController.php         | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
index 9617844b10..2845d0f42b 100644
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -60,10 +60,11 @@ final class DifferentialRevisionViewController extends DifferentialController {
         $repository);
 
     if ($request->getExists('download')) {
-      return $this->buildRawDiffResponse($changesets,
-                                         $vs_changesets,
-                                         $vs_map,
-                                         $repository);
+      return $this->buildRawDiffResponse(
+        $changesets,
+        $vs_changesets,
+        $vs_map,
+        $repository);
     }
 
     $props = id(new DifferentialDiffProperty())->loadAllWhere(
@@ -163,8 +164,8 @@ final class DifferentialRevisionViewController extends DifferentialController {
             phutil_render_tag(
               'p',
               array(),
-              pht('This revision has no specified reviewers and needs review.'.
-                  ' You may want to add some reviewers.')
+              pht('This revision has no specified reviewers and needs '.
+                  'review. You may want to add some reviewers.')
             ));
         }
       }
@@ -495,6 +496,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
           'href'    => "/differential/subscribe/{$action}/{$revision_id}/",
           'name'    => $viewer_is_cc ? 'Unsubscribe' : 'Subscribe',
           'instant' => true,
+          'sigil' => 'workflow',
         );
       } else {
         $links[] = array(