From dce6dd5d02bb3458f6dbf0f87b860a7314d2847d Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 21 Jul 2018 05:39:27 -0700 Subject: [PATCH] Add an explicit "null" to a missed `diffusion.branchquery` callsite to fix Diffusion "Branches" page Summary: See PHI775. See D19499. Originally, see PHI720. D19499 broke the standalone "Branches" page for commits. Normally, you reach this by taking these steps: - View a commit which is contained by 11 or more branches. - Click the "More Branches..." link in the "Branches" field. - You should be taken to a list of all branches which contain the commit. The change to the 'branch' parameter was adjusted in the query that builds the "x, y, z, More Branches..." list, but not on the actual "Branches" list with the full list. Adjust it. Test Plan: - Set display limit to 1, viewed a commit on "master" and "stable", clicked "More Branches". - Before: saw only "master". - After: saw both "master" and "stable". Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D19532 --- .../diffusion/controller/DiffusionBranchTableController.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/diffusion/controller/DiffusionBranchTableController.php b/src/applications/diffusion/controller/DiffusionBranchTableController.php index 441421ba3f..65d7b8fd13 100644 --- a/src/applications/diffusion/controller/DiffusionBranchTableController.php +++ b/src/applications/diffusion/controller/DiffusionBranchTableController.php @@ -22,6 +22,7 @@ final class DiffusionBranchTableController extends DiffusionController { $params = array( 'offset' => $pager->getOffset(), 'limit' => $pager->getPageSize() + 1, + 'branch' => null, ); $contains = $drequest->getSymbolicCommit();