From dd25b2b48bae75db4b9b0c1461a13f06c27263fc Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sun, 16 Oct 2016 08:27:14 -0700 Subject: [PATCH] Remove imagePHIDs column from ConpherenceThread Summary: Ref T11730. Removes the unused column, seen no issues during past week migrations. Test Plan: Run migration, check database no longer contains column. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T11730 Differential Revision: https://secure.phabricator.com/D16711 --- resources/sql/autopatches/20161016.conpherence.imagephids.sql | 2 ++ src/applications/conpherence/storage/ConpherenceThread.php | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 resources/sql/autopatches/20161016.conpherence.imagephids.sql diff --git a/resources/sql/autopatches/20161016.conpherence.imagephids.sql b/resources/sql/autopatches/20161016.conpherence.imagephids.sql new file mode 100644 index 0000000000..98ba1ef5ce --- /dev/null +++ b/resources/sql/autopatches/20161016.conpherence.imagephids.sql @@ -0,0 +1,2 @@ +ALTER TABLE {$NAMESPACE}_conpherence.conpherence_thread + DROP COLUMN imagePHIDs; diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php index 6032835c42..e912f52591 100644 --- a/src/applications/conpherence/storage/ConpherenceThread.php +++ b/src/applications/conpherence/storage/ConpherenceThread.php @@ -10,7 +10,6 @@ final class ConpherenceThread extends ConpherenceDAO protected $title; protected $topic; - protected $imagePHIDs = array(); // TODO; nuke after migrations protected $profileImagePHID; protected $messageCount; protected $recentParticipantPHIDs = array(); @@ -42,7 +41,6 @@ final class ConpherenceThread extends ConpherenceDAO self::CONFIG_AUX_PHID => true, self::CONFIG_SERIALIZATION => array( 'recentParticipantPHIDs' => self::SERIALIZATION_JSON, - 'imagePHIDs' => self::SERIALIZATION_JSON, ), self::CONFIG_COLUMN_SCHEMA => array( 'title' => 'text255?',