revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Don't send empty testplan in e-mail

Browse source 
Summary: Allowed after D2193.

Test Plan: Disable `differential.require-test-plan-field`, create diff without test plan.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D2252
This commit is contained in:
vrana 2012-04-17 00:09:53 -07:00
parent fbfccf5ddc
commit dd7087f4db
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php
View file

@ -56,9 +56,11 @@ abstract class DifferentialReviewRequestMail extends DifferentialMail {
$body[] = null; $body[] = null;
} }
if ($revision->getTestPlan() != '') {
$body[] = 'TEST PLAN'; $body[] = 'TEST PLAN';
$body[] = $this->formatText($revision->getTestPlan()); $body[] = $this->formatText($revision->getTestPlan());
$body[] = null; $body[] = null;
}
} else { } else {
if (strlen($this->getComments())) { if (strlen($this->getComments())) {
$body[] = $this->formatText($this->getComments()); $body[] = $this->formatText($this->getComments());