revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-03 02:18:24 +01:00
Code Issues Releases Wiki Activity

Clean up miscellaneous bot issues

Browse source 
Summary:
Fixes T6073. Fixes T7775. Ref T4377. This fixes a few easy things without any compatibility-breaking changes.

  - Stop matching things like `:D123` as a revision (particularly: IPv6 addresses).
  - Use "diffusion.querycommits".
  - Support "conduit.token".

Test Plan:
Used a token:

```
[07:52am] epriestley: -D22 :D22 #D22 /D22
[07:52am] epriestley: D22
[07:52am] phabot-local: D22: asdbb - http://local.phacility.com/D22
[07:54am] epriestley: rHGTESTX6518697472d6395f5d1cec557148957734aa76c2
[07:54am] phabot-local: http://local.phacility.com/rHGTESTX6518697472d6395f5d1cec557148957734aa76c2
```

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7775, T6073, T4377

Differential Revision: https://secure.phabricator.com/D12773
This commit is contained in:
epriestley 2015-05-08 12:20:44 -07:00
parent 7beae445e9
commit dd88a0e9e9
2 changed files with 26 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/infrastructure/daemon/bot/PhabricatorBot.php
View file

@ -53,8 +53,7 @@ final class PhabricatorBot extends PhabricatorDaemon {
$conduit_uri = idx($config, 'conduit.uri'); $conduit_uri = idx($config, 'conduit.uri');
if ($conduit_uri) { if ($conduit_uri) {
$conduit_user = idx($config, 'conduit.user'); $conduit_token = idx($config, 'conduit.token');
$conduit_cert = idx($config, 'conduit.cert');
// Normalize the path component of the URI so users can enter the // Normalize the path component of the URI so users can enter the
// domain without the "/api/" part. // domain without the "/api/" part.
@ -64,6 +63,12 @@ final class PhabricatorBot extends PhabricatorDaemon {
$conduit_uri = (string)$conduit_uri->setPath('/api/'); $conduit_uri = (string)$conduit_uri->setPath('/api/');
$conduit = new ConduitClient($conduit_uri); $conduit = new ConduitClient($conduit_uri);
if ($conduit_token) {
$conduit->setConduitToken($conduit_token);
} else {
$conduit_user = idx($config, 'conduit.user');
$conduit_cert = idx($config, 'conduit.cert');
$response = $conduit->callMethodSynchronous( $response = $conduit->callMethodSynchronous(
'conduit.connect', 'conduit.connect',
array( array(
@ -74,6 +79,7 @@ final class PhabricatorBot extends PhabricatorDaemon {
'user' => $conduit_user, 'user' => $conduit_user,
'certificate' => $conduit_cert, 'certificate' => $conduit_cert,
)); ));
}
$this->conduit = $conduit; $this->conduit = $conduit;
} }

17
src/infrastructure/daemon/bot/handler/PhabricatorBotObjectNameHandler.php
View file

@ -26,7 +26,7 @@ final class PhabricatorBotObjectNameHandler extends PhabricatorBotHandler {
$pattern = $pattern =
'@'. '@'.
'(?<!/)(?:^|\b)'. '(?<![/:#-])(?:^|\b)'.
'(R2D2)'. '(R2D2)'.
'(?:\b|$)'. '(?:\b|$)'.
'@'; '@';
@ -41,9 +41,11 @@ final class PhabricatorBotObjectNameHandler extends PhabricatorBotHandler {
} }
} }
// Use a negative lookbehind to prevent matching "/D123", "#D123",
// ":D123", etc.
$pattern = $pattern =
'@'. '@'.
'(?<!/)(?:^|\b)'. // Negative lookbehind prevent matching "/D123". '(?<![/:#-])(?:^|\b)'.
'([A-Z])(\d+)'. '([A-Z])(\d+)'.
'(?:\b|$)'. '(?:\b|$)'.
'@'; '@';
@ -158,15 +160,12 @@ final class PhabricatorBotObjectNameHandler extends PhabricatorBotHandler {
if ($commit_names) { if ($commit_names) {
$commits = $this->getConduit()->callMethodSynchronous( $commits = $this->getConduit()->callMethodSynchronous(
'diffusion.getcommits', 'diffusion.querycommits',
array( array(
'commits' => $commit_names, 'names' => $commit_names,
)); ));
foreach ($commits as $commit) { foreach ($commits['data'] as $commit) {
if (isset($commit['error'])) { $output[$commit['phid']] = $commit['uri'];
continue;
}
$output[$commit['commitPHID']] = $commit['uri'];
} }
} }