From dd918b0d148126044adc8f934903818fbaf0e57b Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Fri, 1 Aug 2014 17:22:24 -0700 Subject: [PATCH] Application Search - fix error updating searches from human-readable links Summary: Fixes T5666. When we have a pretty link right now it can conflict with form data; e.g. if you have 'statuses=open' in the URI and then uncheck status = open in the UI, you will still get the open status in the next search. To fix this, set the form action explicitly to lose all the get parameter junk. Test Plan: tried the test case in T5666 / this description and it no longer failed...! Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5666 Differential Revision: https://secure.phabricator.com/D10115 --- .../controller/PhabricatorApplicationSearchController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php index ffec915464..5ce4ad8553 100644 --- a/src/applications/search/controller/PhabricatorApplicationSearchController.php +++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php @@ -153,7 +153,8 @@ final class PhabricatorApplicationSearchController 'query/advanced'); $form = id(new AphrontFormView()) - ->setUser($user); + ->setUser($user) + ->setAction($request->getPath()); $engine->buildSearchForm($form, $saved_query);