From dda06c6bdc7499bd3a500ba8a01f1e105593613c Mon Sep 17 00:00:00 2001 From: Josh Cox Date: Thu, 15 Sep 2016 20:03:18 -0400 Subject: [PATCH] Added a 'name' field to the results for harbormaster.build.search endpoint Summary: Fixes T11642. Added a 'name' field to the results from harbormaster.build.search. Test Plan: Went to `/conduit/method/harbormaster.build.search/` and ran a search that would yield results (because otherwise there will be nothing there). Noted that there was, in fact, a name in the results. Reviewers: yelirekim, #blessed_reviewers, epriestley Reviewed By: yelirekim, #blessed_reviewers, epriestley Subscribers: epriestley, yelirekim Maniphest Tasks: T11642 Differential Revision: https://secure.phabricator.com/D16569 --- .../harbormaster/storage/build/HarbormasterBuild.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuild.php b/src/applications/harbormaster/storage/build/HarbormasterBuild.php index 9255b6ec4a..958eaa1f2b 100644 --- a/src/applications/harbormaster/storage/build/HarbormasterBuild.php +++ b/src/applications/harbormaster/storage/build/HarbormasterBuild.php @@ -420,6 +420,10 @@ final class HarbormasterBuild extends HarbormasterDAO ->setKey('initiatorPHID') ->setType('phid') ->setDescription(pht('The person (or thing) that started this build.')), + id(new PhabricatorConduitSearchFieldSpecification()) + ->setKey('name') + ->setType('string') + ->setDescription(pht('The name of this build.')), ); } @@ -433,6 +437,7 @@ final class HarbormasterBuild extends HarbormasterDAO 'name' => HarbormasterBuildStatus::getBuildStatusName($status), ), 'initiatorPHID' => nonempty($this->getInitiatorPHID(), null), + 'name' => $this->getName(), ); }