From ddde99f80c74adb25efd1904d7b1f8afabda2964 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 22 Oct 2012 17:49:57 -0700 Subject: [PATCH] Flip dem tables on E_COMPILE_ERROR Summary: We currently show the table flipping error page only for E_ERROR and E_PARSE, but should for E_COMPILE_ERROR as well. Test Plan: Added a method with a bad signature to a class. Loaded page. Got a helpful message instead of a blank page. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3791 --- webroot/index.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/webroot/index.php b/webroot/index.php index 63e37caa68..7a50a00beb 100644 --- a/webroot/index.php +++ b/webroot/index.php @@ -327,8 +327,13 @@ function phabricator_shutdown() { return; } - if ($event['type'] != E_ERROR && $event['type'] != E_PARSE) { - return; + switch ($event['type']) { + case E_ERROR: + case E_PARSE: + case E_COMPILE_ERROR: + break; + default: + return; } $msg = ">>> UNRECOVERABLE FATAL ERROR <<<\n\n";