revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-21 14:22:41 +01:00
Code Issues Releases Wiki Activity

DarkConsole: Fix "strlen(null)" but for the "tab" query parameter

Browse source 
Summary:
See rPf4d2811

Bug: T15344

Test Plan: Opened DarkConsole with /~/, saw no errors in DarkConsole

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25834
This commit is contained in:
mainframe98 2024-10-27 19:47:04 +01:00
parent 74bf6c0e3c
commit ddf26e89c8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/console/controller/DarkConsoleController.php
View file

@ -35,7 +35,7 @@ final class DarkConsoleController extends PhabricatorController {
} }
$tab = $request->getStr('tab'); $tab = $request->getStr('tab');
if (strlen($tab)) { if (phutil_nonempty_string($tab)) {
$this->writeDarkConsoleSetting( $this->writeDarkConsoleSetting(
PhabricatorDarkConsoleTabSetting::SETTINGKEY, PhabricatorDarkConsoleTabSetting::SETTINGKEY,
$tab); $tab);