revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 22:40:55 +01:00
Code Issues Releases Wiki Activity

Fix a minor issue in Nuance which could cause the trigger daemon to poll too often

Browse source 
Summary: Ref T10537. Currently, when you have at least two cursors, the daemon can poll too frequently when processing the last source because it never hits the end-of-list condition.

Test Plan:
  - Ran `bin/phd debug trigger`.
  - Observed huge volumes of output before change as triggers fired as fast as possible.
  - Observed reasonable poll frequency after change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10537

Differential Revision: https://secure.phabricator.com/D15464
This commit is contained in:
epriestley 2016-03-11 15:45:17 -08:00
parent 5df5f33909
commit de23ba0002
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php
View file

@ -411,7 +411,7 @@ final class PhabricatorTriggerDaemon
} }
// If we haven't loaded sources yet, load them first. // If we haven't loaded sources yet, load them first.
if (!$this->nuanceSources) { if (!$this->nuanceSources && !$this->nuanceCursors) {
$this->anyNuanceData = false; $this->anyNuanceData = false;
$sources = id(new NuanceSourceQuery()) $sources = id(new NuanceSourceQuery())